Merge pull request #657 from RSilicon/More

Fix some clang-tidy warnings
LIJI32 · Sep 22, 2024 · 73168aa · 73168aa
2 parents f5c7c44 + 7e5996d
commit 73168aa
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Cocoa/GBTerminalTextFieldCell.m b/Cocoa/GBTerminalTextFieldCell.m
@@ -45,7 +45,7 @@ - (instancetype)init
 {
     self = [super init];
     if (!self) {
-        return NULL;
+        return nil;
     }
     lines = [[NSMutableOrderedSet alloc] init];
     return self;

diff --git a/HexFiend/HFPasteboardOwner.m b/HexFiend/HFPasteboardOwner.m
@@ -44,7 +44,7 @@ - (void)tearDownPasteboardReferenceIfExists {
         [[NSNotificationCenter defaultCenter] removeObserver:self name:HFPrepareForChangeInFileNotification object:nil];
     }
     if (retainedSelfOnBehalfOfPboard) {
-        CFRelease(self);
+        [self release];
         retainedSelfOnBehalfOfPboard = NO;
     }
 }

diff --git a/iOS/GBViewController.m b/iOS/GBViewController.m
@@ -612,7 +612,7 @@ - (void)verifyEntitlements
     const char *_teamIdentifier = xpc_dictionary_get_string(entitlements, "com.apple.developer.team-identifier");
     NSString *teamIdentifier = _teamIdentifier? @(_teamIdentifier) : nil;
 
-    CFRelease(entitlements);
+    xpc_release(entitlements);
 
     if (!entIdentifier) { // No identifier. Installed using a jailbreak, we're fine.
         return;