Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix yarn prod for current Angular version #746

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

busser
Copy link
Contributor

@busser busser commented Jan 25, 2024

It seems that since the project updated to a newer version of Angular, the
production build doesn't work anymore. I tracked the issue down to the
src/environments/environment.prod.ts file, which wasn't updated to match the
src/environments/environment.ts file.

Before the fix, yarn prod fails with this error:

./src/environments/environment.ts:5:11-30 - Error: Should not import the named export 'version' (imported as 'packageJson') from default-exporting module (only default export is available soon)

After the fix, yarn prod succeeds.

It seems that since the project updated to a newer version of Angular, the
production build doesn't work anymore. I tracked the issue down to the
`src/environments/environment.prod.ts` file, which wasn't updated to match the
`src/environments/environment.ts` file.

Before the fix, `yarn prod` fails with this error:

```
./src/environments/environment.ts:5:11-30 - Error: Should not import the named export 'version' (imported as 'packageJson') from default-exporting module (only default export is available soon)
```

After the fix, `yarn prod` succeeds.
@kevin-atnos kevin-atnos requested a review from syl-p January 26, 2024 12:59
@kevin-atnos
Copy link
Collaborator

Hello!

Indeed we have noticed this issue too.
Thank you for your contribution, we are merging it right now!

Regards,

@kevin-atnos kevin-atnos self-requested a review January 29, 2024 15:50
@kevin-atnos kevin-atnos merged commit 01cc74e into LINCnil:master Jan 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants