Skip to content

Commit

Permalink
Dense matrix needs RAJA when GPU is used (#676)
Browse files Browse the repository at this point in the history
* dense matrix needs RAJA when GPU is used

* update CMakeList

* add a description

* have an error message when GPU is on but raja is off.
  • Loading branch information
nychiang authored Feb 5, 2024
1 parent 41ef3d3 commit ae5602c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,10 @@ else()
endif()

if(HIOP_USE_GPU)
if(NOT HIOP_USE_RAJA)
message(FATAL_ERROR "Error: HIOP_USE_GPU is ON, but HIOP_USE_RAJA is OFF. HiOp requires using RAJA with CUDA/HIP.")
endif()

include(CheckLanguage)
if(HIOP_USE_MAGMA)
set(HIOP_MAGMA_DIR CACHE PATH "Path to Magma directory")
Expand Down
2 changes: 1 addition & 1 deletion src/LinAlg/LinAlgFactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ hiopMatrixDense* LinearAlgebraFactory::create_matrix_dense(const ExecSpaceInfo&
return nullptr;
#endif //HIOP_USE_RAJA
} else {// for if(hi.exec_backend_ == "RAJA")

assert(false && "device memory backend not available because HiOp was not built with RAJA");
if(mem_space_upper == "CUDA") {
#ifdef HIOP_USE_CUDA
assert(mem_space_upper == "DEVICE");
Expand Down

0 comments on commit ae5602c

Please sign in to comment.