Consolidating qn solver #697
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nychiang this would be a good moment to look into using CI to enforce coding style guidelines. For example, see @tepperly remark here #693 (comment) |
|
@cameronrutherford would you mind checking the failed spack build? maybe we can setup a meeting and I can learn how to fix it from you. |
nychiang
approved these changes
Nov 7, 2024
| // product endorsement purposes. | ||
|
|
||
| /** | ||
| * @file KktLinSysLowRank.cpp |
| @@ -165,10 +172,9 @@ class hiopIterate | |||
| friend class hiopKKTLinSysCompressedXDYcYd; | |||
| friend class hiopKKTLinSysDenseXYcYd; | |||
| friend class hiopKKTLinSysDenseXDYcYd; | |||
| friend class hiopKKTLinSysLowRank; | |||
There was a problem hiding this comment.
do we have plan to drop the term 'hiop' from other classes/file names?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly improving documentation and codestyle for the linear algebra of the quasi-Newton solver.