Fix libROM builds for OSX #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckendrick
requested review from
dylan-copeland,
dreamer2368,
chldkdtn and
siuwuncheung
|
On mac, I get this error for |
dylan-copeland
approved these changes
Jun 6, 2024
|
Could another reviewer please test on mac and approve? |
chldkdtn
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow libROM to be compiled natively again on Mac OSX to fix an error while finding MPI_Fortran. A minor change to the linker flags was added to CMake when building on OSX due to changes made in XCode versions 15.0+ (see https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking).
This was tested on OSX Ventura 13.6.6 using AppleClang 15.0.0, gfortran 13.2.0, and open-mpi 4.1.5, with and without MFEM enabled.