Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tpls #22

Merged
merged 22 commits into from
Aug 9, 2024
Merged

update tpls #22

merged 22 commits into from
Aug 9, 2024

Conversation

artv3
Copy link
Member

@artv3 artv3 commented Jul 24, 2024

No description provided.

@artv3 artv3 requested a review from kab163 July 24, 2024 20:36
@artv3
Copy link
Member Author

artv3 commented Jul 24, 2024

@kab163 , I can't seem to build the suite when we update the tpls.... will have to investigate..

@kab163
Copy link
Contributor

kab163 commented Jul 24, 2024

@kab163 , I can't seem to build the suite when we update the tpls.... will have to investigate..

You'll have to bump up the cmake version to 3.23.1 or higher

@artv3
Copy link
Member Author

artv3 commented Jul 24, 2024

@kab163 , the error I'm hitting locally is the following:

CMake Error at tpl/umpire/cmake/SetupUmpireThirdParty.cmake:83 (blt_install_tpl_setups):
  Unknown CMake command "blt_install_tpl_setups".
Call Stack (most recent call first):
  tpl/umpire/CMakeLists.txt:135 (include)

@rhornung67
Copy link
Member

@artv3 which version of BLT are you using? That command was added recently. I don't recall if it was in a BLT release before v0.6.2.

@artv3
Copy link
Member Author

artv3 commented Jul 25, 2024

@artv3 which version of BLT are you using? That command was added recently. I don't recall if it was in a BLT release before v0.6.2.

Good catch! Updating BLT to v0.6.2 fixed things for me.

@artv3
Copy link
Member Author

artv3 commented Aug 7, 2024

@davidbeckingsale would you have some time to help us update the cmake in the docker container?

@artv3 artv3 merged commit dc4866e into main Aug 9, 2024
1 check passed
@artv3 artv3 deleted the artv3/update-tpl branch August 9, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants