Sorting out boundary conditions #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs some modifications for the linear elasticity parameterized problem to work. |
larsson4
reviewed
Mar 4, 2024
| @@ -427,14 +428,20 @@ void LinElastSolver::SetupDomainBCOperators() | |||
| continue; | |||
| if (!BCExistsOnBdr(b)) | |||
| continue; | |||
| as[m]->AddBdrFaceIntegrator(new DGElasticityIntegrator(*(lambda_c[m]), *(mu_c[m]), alpha, kappa), *(bdr_markers[b])); | |||
|
|
|||
| if (bdr_type[b] == BoundaryType::DIRICHLET) | |||
There was a problem hiding this comment.
This should also be true for the Zero Neumann condition.
There was a problem hiding this comment.
Are you sure about this? zero Neumann condition will be filtered out at the previous if clause, both previous and current version.
There was a problem hiding this comment.
No I think that you're right. The examples all seem to work well now.
larsson4
reviewed
Mar 4, 2024
larsson4
approved these changes
Mar 4, 2024
| @@ -427,14 +428,20 @@ void LinElastSolver::SetupDomainBCOperators() | |||
| continue; | |||
| if (!BCExistsOnBdr(b)) | |||
| continue; | |||
| as[m]->AddBdrFaceIntegrator(new DGElasticityIntegrator(*(lambda_c[m]), *(mu_c[m]), alpha, kappa), *(bdr_markers[b])); | |||
|
|
|||
| if (bdr_type[b] == BoundaryType::DIRICHLET) | |||
There was a problem hiding this comment.
No I think that you're right. The examples all seem to work well now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BoundaryTypeis now independent, applicable to all problems.BoundaryType::ZEROis reserved for zero Dirichlet boundary condition.MultiBlockSolverhasArray<BoundaryType> bdr_type, indicating boundary types for all global boundary attributes.MultiBlockSolver::SetParameterizedProblemspecifiesbdr_typeaccording toproblem. Executed in all derived classes.SetupBCOperatornow supports various boundary conditions depending on Dirichlet/Neumann boundary types, specified by member variablebdr_type.MultiBlockSolver::BCExistsOnBdrstill behaves the same as before, returning whether a boundary condition is specified.