Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libROM / MFEM v4.6 updates + Advection-diffusion #31

Merged
merged 14 commits into from
Mar 19, 2024
Merged

Conversation

dreamer2368
Copy link
Collaborator

@dreamer2368 dreamer2368 commented Mar 14, 2024

libROM PR #274 update

  • dataset name change for libROM snapshot matrix files: dataset suffix _000000 is removed.
  • Enforced the use of CAROM::Dataset::formats

MFEM v 4.6 update

MUMPSSolver changes

  • MUMPSSolver initialization requires MPI_Comm
  • MUMPSSolver::MatType is changed.
    • Now StokesSolver should use MUMPSSolver::MatType::SYMMETRIC_INDEFINITE.
    • StokesSolver::SetupMUMPSSolver takes input argument bool set_oper and uses MUMPSSolver::SetOperator only if set_oper is true. For SteadyNSSolver, set_oper is set false.

SubMesh changes

  • SubMesh does not use SubMesh::GENERATED_ATTRIBUTE any more for the generated boundaries of submeshes, instead parent.bdr_attributes.Max() + 1.
  • Reflecting this, boundary attributes for interfaces are set from parent.bdr_attributes.Max() + 2, both for SubMeshTopologyHandler and ComponentTopologyHandler.
  • Minor fix in ComponentTopologyHandler::SetupReferencePorts: the input mesh/component-wise/ports/.../file for port file name is optional.

Advection-diffusion equation

  • AdvDiffSolver solves the advection-diffusion equation given a Peclet number.
  • The velocity field must be provided either in analytic form or with a solution from StokesSolver or SteadyNSSolver.
  • Currently StokesSolver or SteadyNSSolver only provides FOM velocity field.
    • This limits ROM for AdvDiffSolver to be always built from a global system. Fully component-wise ROM for AdvDiffSolver requires taking velocity POD basis from StokesSolver or SteadyNSSolver.

@dreamer2368 dreamer2368 changed the title initial loading of advection-diffusion solver Advection-diffusion demonstration Mar 14, 2024
@dreamer2368 dreamer2368 changed the title Advection-diffusion demonstration libROM / MFEM v4.6 updates + Advection-diffusion demonstration Mar 16, 2024
@dreamer2368 dreamer2368 changed the title libROM / MFEM v4.6 updates + Advection-diffusion demonstration libROM / MFEM v4.6 updates + Advection-diffusion Mar 16, 2024
@dreamer2368 dreamer2368 marked this pull request as ready for review March 16, 2024 21:23
@dreamer2368 dreamer2368 merged commit 47cf861 into main Mar 19, 2024
2 checks passed
@dreamer2368 dreamer2368 deleted the adv-diff branch July 9, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant