Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_ckpt.C #183

Merged
merged 1 commit into from
May 18, 2020
Merged

Update test_ckpt.C #183

merged 1 commit into from
May 18, 2020

Conversation

tonyhutter
Copy link
Contributor

@tonyhutter tonyhutter commented May 15, 2020

  • Rename test_ckpt.C -> test_ckpt.cpp
  • Update it so it can be easily used as C code as well.
  • Allow it to take in an argument for checkpoint size in MB

These changes will help me with testing in #163.

@adammoody
Copy link
Contributor

Hi @tonyhutter , we had added a C++ test intentionally after we found out one time that C++ codes could not easily use SCR. At that time, we were missing extern "C" statements. It's alright to have a C version, we'll want to keep a C++ program, too.

@tonyhutter tonyhutter force-pushed the test_ckpt_fixes branch 2 times, most recently from a75e6f5 to afa51b9 Compare May 15, 2020 18:49
@tonyhutter tonyhutter changed the title Update test_ckpt.c Update test_ckpt.C May 15, 2020
@tonyhutter
Copy link
Contributor Author

@adammoody thanks for the info. My latest push renames it test_ckpt.cpp and I added some trivial C++isms to get it to build as C++.

@adammoody
Copy link
Contributor

Looks good to me. Thanks. This ready for merge, @tonyhutter?

@tonyhutter
Copy link
Contributor Author

Almost, let me update these additional references to test_ckpt.C

examples/test_ckpt.cpp:1:// mpig++ -g -O0 -I../src -o test_ckpt_C test_ckpt.C -L/usr/local/tools/scr-1.1/lib -lscr
examples/makefile.examples.in:30:test_ckpt_C: test_ckpt.C
examples/makefile.examples.in:31:	$(MPICXX) $(OPT) $(CXXFLAGS) $(INCLUDES) -o test_ckpt_C test_ckpt.C \
build/examples/makefile.examples:30:test_ckpt_C: test_ckpt.C
build/examples/makefile.examples:31:	$(MPICXX) $(OPT) $(CXXFLAGS) $(INCLUDES) -o test_ckpt_C test_ckpt.C \

- Rename test_ckpt.C -> test_ckpt.cpp
- Update it so it can be easily used as C code as well.
- Allow it to take in an argument for checkpoint size in MB

These changes will help me with testing in LLNL#163.
@tonyhutter
Copy link
Contributor Author

Should be good now

@adammoody adammoody merged commit 7964ebf into LLNL:develop May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants