Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homebrew-based build instructions for apple silicon #1159

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

zatkins-work
Copy link
Contributor

Updates the build documentation to work for M2 macbooks. This will likely need to be revised to support x86_64 and other apple silicon.

@zatkins-work zatkins-work added documentation Improvements or additions to documentation WIP Work in progress labels Jun 28, 2024
@zatkins-work zatkins-work self-assigned this Jun 28, 2024
@zatkins-work zatkins-work force-pushed the doc/atkins12/macos-build-docs branch from 60c916a to 994ae23 Compare June 28, 2024 20:59
@white238
Copy link
Member

There are some warnings/errors in the docs build. I attach them here in case you can't view the page. I can't remember who can/cannot...

/home/serac/serac/src/docs/sphinx/quickstart.rst:282: WARNING: Unexpected indentation.
/home/serac/serac/src/docs/sphinx/quickstart.rst:286: WARNING: Unexpected indentation.
/home/serac/serac/src/docs/sphinx/quickstart.rst:297: WARNING: Unexpected indentation.
/home/serac/serac/src/docs/sphinx/quickstart.rst:305: WARNING: Unexpected indentation.
/home/serac/serac/src/docs/sphinx/quickstart.rst:306: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/serac/serac/src/docs/sphinx/quickstart.rst:313: WARNING: Unexpected indentation.
/home/serac/serac/src/docs/sphinx/quickstart.rst:315: WARNING: Unexpected indentation.
/home/serac/serac/src/docs/sphinx/quickstart.rst:319: WARNING: Unexpected indentation.
/home/serac/serac/src/docs/sphinx/quickstart.rst:320: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/serac/serac/src/docs/sphinx/quickstart.rst:322: WARNING: Unexpected indentation.
/home/serac/serac/src/docs/sphinx/quickstart.rst:326: WARNING: Unexpected indentation.
/home/serac/serac/src/docs/sphinx/quickstart.rst:333: WARNING: Error in "code-block" directive:
/home/serac/serac/src/docs/sphinx/quickstart.rst:338: WARNING: Error in "code-block" directive:

@white238
Copy link
Member

@zatkins-work This looks great and I very much appreciate the extra effort this took. As soon as you fix the few formatting issues we will get this merged!

Copy link
Contributor

@chapman39 chapman39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zatkins-work !

@zatkins-work zatkins-work force-pushed the doc/atkins12/macos-build-docs branch from 7864b84 to 09d5e38 Compare July 1, 2024 22:30
@zatkins-work zatkins-work force-pushed the doc/atkins12/macos-build-docs branch from 09d5e38 to 30d0390 Compare July 2, 2024 20:10
@zatkins-work zatkins-work enabled auto-merge (squash) July 2, 2024 20:10
@zatkins-work zatkins-work merged commit da02375 into develop Jul 2, 2024
2 checks passed
tupek2 pushed a commit that referenced this pull request Jul 6, 2024
* Add homebrew-based build instructions for apple silicon

* Update scripts/spack/configs/macos_sonoma_aarch64/spack.yaml

Use `::` to prevent use of other compilers

Co-authored-by: Chris White <[email protected]>

* Fix code block formatting

* Update src/docs/sphinx/quickstart.rst

Co-authored-by: Chris White <[email protected]>

---------

Co-authored-by: Chris White <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants