-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bezier curves for automation tracks #2466
Conversation
Some notes...
|
Looks like the windows builds are failing, that's what you get when you remove the execute bit on build scripts... |
I've fixed the compile problems. I must've accidentally done something to the windows build scripts so I just copied the master branch's code over. |
@codythecoder first, backup the files you've changed. Then rewind your branch. One way to do this is a Next, fast-forward your branch to have the latest from upstream. Last, re-apply your changes manually (commit them, force push them). Once they're on your fork, this PR will be updated automatically. That's not to say your existing commits can't be resurrected, but a bad rebase is hard to unwind, sometimes it's easier to just start from scratch. 👍 |
Can someone help me figure out what's going on with the build fails? It's giving me warnings about packages not being authenticated, but I'm not sure how to fix this or what I could have done to cause this. After this is solved, it should be ready to merge with master. |
|
@codythecoder, I re-started the Travis-CI builds. I don't think the errors are related to your commit specifically. Let's see if they're in better shape in a few minutes here. |
Cool, so that works now. I just realized that I still have to change one thing, which I just have to test and commit, so that will be done in a few minutes. |
Ok, that's all ready :) |
Build failed again. I restarted it but it wouldn't work anyway... |
Yeah, Travis is having some technical difficulties. There's a GPG key here which is unreachable at the moment, causing some dependencies to fail, thus false-positively failing the tests. This missing Canonical/Ubuntu GPG key is affecting all builds which are Ubuntu-derived (QT4, QT5, Win32, Win64). Apple isn't affected since it uses Homebrew for all of its dependencies. Ubuntu 12.04 ("Precise") isn't EOL until April 2017 so the mirrors should be up for another 15 months. Simply re-running the Travis build process again a bit later will likely resolve this. 👍 |
Travis-CI is passing. 👍 |
I'm all done with this, when can we get this merged? |
@codythecoder Is it intentional that when you move a point its handles will reset? |
@grejppi Yes, when I wrote it, it was intentional. Getting the dragging to work was one of the first things I had to do, and due to how point dragging is normally done, I thought it would be impossible to get the control points to move along with the automation point, and I just forgot about it. |
I've got it to drag the control points along with the automation points, I think that's everything, but if people could test it while I fix the conflicts, that would be great. |
This pull request has merge conflicts and needs to be rebased against current master. |
😆 |
Still, it's well within my usual margin of error...
It crashes for me. Both rebased and in present form. I'll try and add some debug data later. |
Crashes when I click in the autmation pattern.
Backtrace
|
@zonkmachine I'll have a look at that after I finish with the conflicts, since there's a chance it'll just fix itself automatically. What system are you running it on? |
Sorry! I should have mentioned that this was done rebased. Maybe I should wait to test it more until you've updated so we're working on the same source? I'll try and get some data from 1f25d1c instead.
Linux Mint 17.3 |
Same result.
The Edit: Version 1.1.90-g1f25d1c (Linux/x86_64, Qt 4.8.6, GCC 4.8.4) |
I think I know where the error is coming from, so I'll see if I can get it to crash for me when I have some time. My guess is that |
Oops I pressed the wrong button 😄 |
It's green. It had some validation issues with some packages. Had to kick start it a few times. (You're right not your fault.) |
@tresf cool 👍 now I guess it's just wait to see if any more problems arise? |
@zonkmachine can merge if he's comfortable with it and has tested it. 👍 |
New crash. I got it when looping a BBTrack over four bars and modulating the cutoff on a 3osc with a bezier curve.
|
@zonkmachine If you save and load does it still crash? If it does, could you send the file to me and I can check it out. Also, could you copy this code into its spot in
|
Yes
It counts 1 2 3 and never prints 0. It most often crash on 1 not as often on 2 and rarely on 3. |
Sorry for the silence, uni and whatnot got in the way. If you go back to
|
Hi, finally got the time to sit down and try this but unfortunately it works well... 😒 |
It's only in programming that it can be unfortunate when something works 😄 I'll push these changes anyway, maybe someone else'll have the same problem later, and hopefully this'll fix anything that would've crashed. |
fixes things I hope
# Conflicts: # src/core/AutomationPattern.cpp
👍 Crashed when manipulating one of the control points. Just looping the track worked well.
|
@codythecoder This PR has conflicts (Probably Since 41b930e). Since it looks like it was mostly I who had issues with this PR, maybe it should be tested by someone else too? I'm off course happy to test anything you throw at me but I'd prefer it as a patch ( |
What's the news on this? This would be such an amazing feature!! Glad to see it's still in the works anywho, and thanks for the effort toward something that would be so helpful :D 🍡 |
That you just volonteered to test this PR. 😃 |
News of this has been that I've been busy (and not to mention lazy) but it's probably time I finish it once and for all 😁 The only known problems remaining are: moving the control points while playing through the track will occasionally cause it to crash, and now of course it has merge conflicts. I'll see what I can get done by the end of the week, but if you can find any other errors that's also good. |
@codythecoder Are you still here? If you are, could you continue your work?
Confirmed. If the OP @codythecoder is not here, maybe I can investigate it and open a new PR. |
I'll see what I can do. I'll get you more details once I get the workflow setup on my new computer. |
Pro Tip: Try to use |
@codythecoder Are you willing to continue working on this pull request? |
I'll have a good look tomorrow, but I imagine so. Otherwise yeah, I'll have to rely on one of you to do it |
@codythecoder Then may I continue your work? |
Continued in #4674. @codythecoder Thank you for the code! |
Based on this issue, I think having bezier curves in LMMS would make automation tracks a lot more powerful, and much faster to do certain types of curves.