Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SlewDistortion effect and oversampling support #7641
base: master
Are you sure you want to change the base?
Add SlewDistortion effect and oversampling support #7641
Changes from 1 commit
6d89189
6220dc9
eb95119
339e168
0667aa3
7da5714
a18085c
058397d
bd0fc13
c64548c
ead1530
83b879c
066f49f
ceb8408
40a15da
0de389a
372edf4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why these variables are stored in arrays of length 4, if the first two and last two are the same. Is it to match the way SSE2 works with vectors of 4 floats at a time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This obviously isn't the way you'd want to do things normally, but I was writing the code with the intention of converting it over to SSE2 from day 1. This non-SSE2 code won't ever run for over 99.99% of people, so it's best to essentially treat it as a giant comment, so you can see what the SSE2 code is achieving if you don't understand a certain part of it.
Check notice on line 667 in plugins/SlewDistortion/SlewDistortion.cpp
codefactor.io / CodeFactor
plugins/SlewDistortion/SlewDistortion.cpp#L64-L667
Check notice on line 376 in plugins/SlewDistortion/SlewDistortionControlDialog.cpp
codefactor.io / CodeFactor
plugins/SlewDistortion/SlewDistortionControlDialog.cpp#L189-L376