Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set Qt::WA_OpaquePaintEvent #7643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion plugins/Compressor/CompressorControlDialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ CompressorControlDialog::CompressorControlDialog(CompressorControls* controls) :
m_controls(controls)
{
setAutoFillBackground(false);
setAttribute(Qt::WA_OpaquePaintEvent, true);
setAttribute(Qt::WA_NoSystemBackground, true);

setMinimumSize(MIN_COMP_SCREEN_X, MIN_COMP_SCREEN_Y);
Expand Down
2 changes: 0 additions & 2 deletions src/gui/clips/AutomationClipView.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ AutomationClipView::AutomationClipView( AutomationClip * _clip,
connect( getGUI()->automationEditor(), SIGNAL(currentClipChanged()),
this, SLOT(update()));

setAttribute( Qt::WA_OpaquePaintEvent, true );

setToolTip(m_clip->name());
setStyle( QApplication::style() );
update();
Expand Down
1 change: 0 additions & 1 deletion src/gui/clips/ClipView.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ ClipView::ClipView( Clip * clip,
s_textFloat->setPixmap( embed::getIconPixmap( "clock" ) );
}

setAttribute( Qt::WA_OpaquePaintEvent, true );
setAttribute( Qt::WA_DeleteOnClose, true );
setFocusPolicy( Qt::StrongFocus );
setCursor( m_cursorHand );
Expand Down
2 changes: 0 additions & 2 deletions src/gui/editors/AutomationEditor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,6 @@ AutomationEditor::AutomationEditor() :
connect( Engine::getSong(), SIGNAL(timeSignatureChanged(int,int)),
this, SLOT(update()));

setAttribute( Qt::WA_OpaquePaintEvent, true );

//keeps the direction of the widget, undepended on the locale
setLayoutDirection( Qt::LeftToRight );

Expand Down
2 changes: 0 additions & 2 deletions src/gui/editors/PianoRoll.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,6 @@ PianoRoll::PianoRoll() :
s_textFloat = new SimpleTextFloat;
}

setAttribute( Qt::WA_OpaquePaintEvent, true );

// add time-line
m_timeLine = new TimeLineWidget(m_whiteKeyWidth, 0, m_ppb,
Engine::getSong()->getPlayPos(Song::PlayMode::MidiClip),
Expand Down
1 change: 0 additions & 1 deletion src/gui/editors/TimeLineWidget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ TimeLineWidget::TimeLineWidget(const int xoff, const int yoff, const float ppb,
m_begin{begin},
m_mode{mode}
{
setAttribute( Qt::WA_OpaquePaintEvent, true );
move( 0, yoff );

setMouseTracking(true);
Expand Down
1 change: 0 additions & 1 deletion src/gui/instrument/PianoView.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ PianoView::PianoView(QWidget *parent) :
m_lastKey(-1), /*!< The last key displayed? */
m_movedNoteModel(nullptr) /*!< Key marker which is being moved */
{
setAttribute(Qt::WA_OpaquePaintEvent, true);
setFocusPolicy(Qt::StrongFocus);

// Black keys are drawn halfway between successive white keys, so they do not
Expand Down
1 change: 0 additions & 1 deletion src/gui/tracks/FadeButton.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ FadeButton::FadeButton(const QColor & _normal_color,
m_activatedColor( _activated_color ),
m_holdColor( holdColor )
{
setAttribute(Qt::WA_OpaquePaintEvent, true);
setCursor(QCursor(embed::getIconPixmap("hand"), 3, 3));
setFocusPolicy(Qt::NoFocus);
activeNotes = 0;
Expand Down
1 change: 0 additions & 1 deletion src/gui/tracks/TrackLabelButton.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ TrackLabelButton::TrackLabelButton( TrackView * _tv, QWidget * _parent ) :
m_trackView( _tv ),
m_iconName()
{
setAttribute( Qt::WA_OpaquePaintEvent, true );
setAcceptDrops( true );
setCursor( QCursor( embed::getIconPixmap( "hand" ), 3, 3 ) );
setToolButtonStyle( Qt::ToolButtonTextBesideIcon );
Expand Down
1 change: 0 additions & 1 deletion src/gui/widgets/CPULoadWidget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ CPULoadWidget::CPULoadWidget( QWidget * _parent ) :
m_changed( true ),
m_updateTimer()
{
setAttribute( Qt::WA_OpaquePaintEvent, true );
setFixedSize( m_background.width(), m_background.height() );

m_temp = QPixmap( width(), height() );
Expand Down
1 change: 0 additions & 1 deletion src/gui/widgets/Fader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ Fader::Fader(FloatModel* model, const QString& name, QWidget* parent) :
}

setWindowTitle(name);
setAttribute(Qt::WA_OpaquePaintEvent, false);
// For now resize the widget to the size of the previous background image "fader_background.png" as it was found in the classic and default theme
constexpr QSize minimumSize(23, 116);
setMinimumSize(minimumSize);
Expand Down
1 change: 0 additions & 1 deletion src/gui/widgets/Oscilloscope.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ Oscilloscope::Oscilloscope( QWidget * _p ) :
m_clippingColor(255, 64, 64)
{
setFixedSize( m_background.width(), m_background.height() );
setAttribute( Qt::WA_OpaquePaintEvent, true );
setActive( ConfigManager::inst()->value( "ui", "displaywaveform").toInt() );

const fpp_t frames = Engine::audioEngine()->framesPerPeriod();
Expand Down
Loading