Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Mixer Channel Selection #7714

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

regulus79
Copy link
Contributor

This PR adds the ability to select multiple mixer channels at once and do simple operations on all of them, such as sending, muting, deleting, and changing color.

Implementation

  • The currently selected mixer channels are stored in a std::set within MixerChannelView
  • Lots of methods which used to work on a single channel have been changed to work with the entire selection of channels In particular,
    • Send/unsend
    • Changing color
    • Moving left/right
    • Deleting selected channels
    • Muting/soloing

Known Bugs

  • Bulk solo is buggy
  • Bulk moving left/right is buggy when some unselected channels have send/receives. I'm not sure why.

Now that I think about it, this code is really messy and this probably isn't the best way to handle it. If you all don't think this is a good PR, I can wait for someone else to do it better lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant