-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #311 create cl make bin stage #314
Conversation
…e_#311_create_CL_make_bin_stage
…e_#311_create_CL_make_bin_stage
…e_#311_create_CL_make_bin_stage
For the CLClusterBinningRedshiftRichness stage :
I explicitly wrote different bin definition in the config file and as the default in the pipeline stage to make it explicit in the notebook which is what. |
@cavestruz : the PR is ready on my side. Normally you should have all info from the notebook! Please test the nersc launcher (just for the 1deg2 should be sufficient) as I did not test it. We should find better way to work at the two site with changing just the launcher file, but I did not find the proper way to do it. So you also have to change the first lines in the pipeline files. |
…e comment/uncommenting happen in the notebook level
…he comment/uncommenting happen in the notebook level
… steps between NERSC/IN2P3. Now, there are separate files for each.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Primary changes are to change the 20sqdeg yaml files so this works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing this submission in NERSC.
sbatch examples/cosmodc2/1deg2-nersc.sub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this file to two separate config-1deg2-CL-{in2p3,nersc}.yml and put each option in the notebook, Run_CL_pipeline.ipynb
so the comment/uncommenting happens at the notebook level as opposed to inside the yml file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This has some lines that need updating to run, consistent with the 1deg2 version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This has some lines that need updating to run, consistent with the 1deg2 version.
notebooks/Run_CL_pipeline.ipynb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some minor additions here to account for different in2p3 vs. nersc files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made minor change here, so there are separate yaml files depending on where the user is running the notebook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing this out now with the squeue
submission. Will then check if latter portion of notebook runs on NERSC with the output of the 20deg2 submission that uses this yaml file.
@cavestruz : I did some cleaning as there were typos in the files and reorganized the notebook to clarify the 2 approaches to run : direclty from jupyter or via pipeline/ceci. I commented all unused stages / input so that the pipeline chart for this PR is just: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - I am able to run everything in the notebook, and submit the sbatch examples/cosmodc2/20deg2-nersc.sub
to run the tail end of cells in Run_CL_counts_pipeline.ipynb
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing this out now with the squeue
submission. Will then check if latter portion of notebook runs on NERSC with the output of the 20deg2 submission that uses this yaml file.
Linked to #311. This issue creates a stage to bin the cluster catalogs in bins of richness and redshift and output a tomography TX file. Pipeline and config files are also written to run the CL pipeline, as well as the batch script for CCin2p3 and a notebook running the pipeline and exploring the input and output files.