Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSI DES inputs #358

Merged
merged 13 commits into from
Oct 11, 2024
Merged

SSI DES inputs #358

merged 13 commits into from
Oct 11, 2024

Conversation

elvinpoole
Copy link
Collaborator

@elvinpoole elvinpoole commented Jul 5, 2024

Furthers the SSI SRV inputs PR by including inputs from the DES Balrog runs
This is being used to demonstrate the magnification stage runs as expected

@elvinpoole elvinpoole marked this pull request as ready for review September 20, 2024 15:50
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get the DES maglim selection from Balrog catalogs, I included the EXTENDED_CLASS_SOF (the star galaxy separator) and FLAGS_GOLD columns.

Alternatively, we could rename these columns in the ingestion stage to something more Rubin-like and use these. Depends on how generic we want the lens selector options to be

Copy link
Collaborator

@joezuntz joezuntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just some minor requests.

txpipe/ingest/ssi.py Show resolved Hide resolved
txpipe/ingest/ssi.py Show resolved Hide resolved
txpipe/lens_selector.py Outdated Show resolved Hide resolved
@joezuntz joezuntz merged commit d865904 into master Oct 11, 2024
15 checks passed
@joezuntz joezuntz deleted the ssi_des_inputs branch October 11, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants