Add ComCam vignetting #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchiang87
approved these changes
Feb 28, 2024
devel-tools/vignetting/README.md
Outdated
| @@ -14,10 +15,12 @@ Instructions for generating vignetting spline fits. | |||
| photons per star. Currently, `magnorm=22.25` will produce ~100k | |||
| incident photons per star. | |||
|
|
|||
| 4. To run the simulation run `galsim imsim-vignetting.yaml`. | |||
| 4. To run the simulation run `galsim imsim-vignetting.yaml`. For | |||
| ComCam, you can add `eval_variables.bisComCam=True`. | |||
There was a problem hiding this comment.
What does adding this do?
There was a problem hiding this comment.
It sets this eval variable, which is then used in the yaml file to select between comcam/lsstcam settings in a few places. E.g., here.
The b in bisComCam (for boolean) is unfortunate. (Would have been nice to just have isComCam which is more readable.). But that's a limitation of the galsim config system. I can add a bit more text to the README.
There was a problem hiding this comment.
Maybe bIsComCam or bUseComCam is better?
There was a problem hiding this comment.
Okay, I updated the README text and went with bIsComCam.
jmeyers314
force-pushed
the
comcam_vignetting
branch
from
857315b
to
34357bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the files in devel-tools/vignetting to handle both LsstCam and ComCam. I made one algorithmic tweak, which was to reflect the input (radius, flux) data about the radius=0 axis so when fitting the spline, the symmetry of the input data and knots forces the spline to have zero derivative at radius=0.
ComCam and (updated) LsstCam pngs below:
To use the new vignetting profile for ComCam, update your yaml config with: