Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin rubin-sim in conda reqs #454

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Unpin rubin-sim in conda reqs #454

merged 5 commits into from
Mar 19, 2024

Conversation

jmeyers314
Copy link
Member

No description provided.

Copy link
Member

@cwwalter cwwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. but do we want to pin it at 2.0.0 or leave it free?

@jchiang87
Copy link
Collaborator

I think we want to pin it at some version to avoid problems with the unit tests, especially the sky model tests. That's why it was pinned at 1.1.1.

@rmjarvis
Copy link
Contributor

If possible, we should try to leave it unpinned and only pin it again if there are problems. People in the wild will continue to have whatever the latest is, so we will want to know when that is not compatible with how we are using it.

@jmeyers314
Copy link
Member Author

I don't understand. If I conda install ... packages one at a time, things work. If I conda install --file standalone_conda_requirements.txt" the same packages, then conda stdouts that it's done, but returns a non-zero exit status anyway so GHA thinks error. Gonna try with || true...

@jmeyers314
Copy link
Member Author

Seemed to get farther? But similar error when installing the test requirements? adding more || true...

@jmeyers314
Copy link
Member Author

Okay, that seems to have worked (rebasing now to clean up the history). Note I fixed a deprecation warning too in case anyone wants to review that.

@cwwalter
Copy link
Member

The pickle to fits change of the fringing file is for the deprecation warning?

@jmeyers314
Copy link
Member Author

The pickle to fits change of the fringing file is for the deprecation warning?

Exactly. The pickle was holding a deprecated interpolation object, so I extracted the values-to-be-interpolated and put them in a fits instead.

@jmeyers314 jmeyers314 merged commit 7237452 into main Mar 19, 2024
3 checks passed
@jmeyers314 jmeyers314 deleted the CI_w_unpinned_rubin_sim branch March 19, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants