-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin rubin-sim in conda reqs #454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.. but do we want to pin it at 2.0.0 or leave it free?
I think we want to pin it at some version to avoid problems with the unit tests, especially the sky model tests. That's why it was pinned at 1.1.1. |
If possible, we should try to leave it unpinned and only pin it again if there are problems. People in the wild will continue to have whatever the latest is, so we will want to know when that is not compatible with how we are using it. |
I don't understand. If I |
Seemed to get farther? But similar error when installing the test requirements? adding more |
4dc10fb
to
bf93f8a
Compare
Okay, that seems to have worked (rebasing now to clean up the history). Note I fixed a deprecation warning too in case anyone wants to review that. |
The pickle to fits change of the fringing file is for the deprecation warning? |
Exactly. The pickle was holding a deprecated interpolation object, so I extracted the values-to-be-interpolated and put them in a fits instead. |
No description provided.