Delay read of instcat until data is needed #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now the catalog is read once for a single CCD However it is still reading it again for each CCD that is simulated. |
Yes, it selects the galaxies in the input catalog that will fall on (or near) the CCD, so that is required. |
esheldon
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #464 take two.
I removed the approx_nobject keyword, and now implement getApproxNObjects() by just counting the lines in the instance catalog file. This will always be >= the number of objects in that file that fall on the image, so it works as a good approx value. And it's quite fast, so should address the original problem about reading the file twice taking a long time.