Refactor stamp.py #468
Merged
Refactor stamp.py #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flake8 was calling out a lot of style issues, turn those off
Pull out some useful functionality.
Useful stuff for calculating stamp sizes was put into stamp_utils.py
get_stamp_size (was in LSST_SiliconBuilder.__init__)
get_star_stamp_size
get_gal_stamp_size
get_good_phot_stamp_size (was LSST_SiliconBuilder._getGoodPhotImageSize)
get_good_phot_stamp_size1 (was LSST_SiliconBuilder._getGoodPhotImageSize1)
Useful stuff for psfs was put into psf_utils.py
make_double_gaussian (was LSST_SiliconBuilder.DoubleGaussian)
make_kolmogorov_and_gaussian_psf was (LSST_SiliconBuilder.Kolmogorov_and_Gaussian_PSF)
make_fft_psf (was LSST_SiliconBuilder.make_fft_psf)
Make optional
|
Who wants to take this one? |
|
The data download failed in the CI. I don't have permission to rerun the workflow, can someone please kick that off? |
rmjarvis
approved these changes
May 10, 2024
imsim/stamp_utils.py
Outdated
|
|
||
| def get_gal_stamp_size(obj_achrom, nominal_flux, noise_var, Nmax, pixel_scale): | ||
| """ | ||
| Get a stamp size for a star (DeltaFunction) object |
|
Is this OK to merge now? |
|
It's fine by me, but I usually let Jim or Chris make the call. |
|
It's ok with me. |
|
OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull out some useful functionality.
Add a .flake8 to avoid some style complaints