-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header fixes and LSSTCamSim support #473
Conversation
71401e9
to
303954a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
telcode = 'MC' | ||
dayobs = eimage.header['DAYOBS'] | ||
seqnum = eimage.header['SEQNUM'] | ||
contrllr = eimage.header['CONTRLLR'] | ||
phdu.header['TELESCOP'] = SIMONYI_TELESCOPE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe factor out some of the other common keywords too? E.g., 'RAFTBAY', 'CCDSLOT', 'RA', 'DEC', 'ROTCOORD', 'ROTPA', ...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to do that more cleanly, I'd like to get rid of support for LsstCamImSim
, otherwise I suspect the number of if
statements will actually increase. In fact, in addition to getting rid of LsstCamImSim
support, I'd like to support just *Sim
cameras explicitly, e.g., LsstCamSim
and LsstComCamSim
, so also removing LsstCam
as an option. I'll post an issue with this proposal.
if eimage.header['IMGTYPE'] == 'SKYEXP': | ||
phdu.header['RADESYS'] = 'ICRS' | ||
phdu.header['TRACKSYS'] = 'RADEC' | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When does this get used? Simulated flats?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(by this, I mean TRACKSYS = LOCAL).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for anything not on-sky, specifically any calibration frames.
303954a
to
af7bcf7
Compare
…out contents of test eimage file and compress
af7bcf7
to
4c167f2
Compare
No description provided.