Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

U/jrbogart/sso ops4 #108

Merged
merged 2 commits into from
Jun 17, 2024
Merged

U/jrbogart/sso ops4 #108

merged 2 commits into from
Jun 17, 2024

Conversation

JoanneBogart
Copy link
Collaborator

@JoanneBogart JoanneBogart commented Jun 13, 2024 •
edited
Loading

  1. Updates when reading SSO inputs to accommodate column name changes for ops rehearsal 4
  2. Get rid of unnecessary global declaration
  3. Update for compatibility with name changes in creation script options (e.g. --no-main rather than --flux-only)
  4. Fix units bug when making a streak (galsim box)

@JoanneBogart
Changes needed to create SSO catalogs from newer input
8bf723e 
 - column names have changed
 - some of the SSO code was not up to date with other changes within
   skyCatalogs
 - other cosmetic changes
@JoanneBogart
fix units bug
c1f154f
jchiang87
jchiang87 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. One of these days, I think we should move all of the streak calculations to sso_catalog_creator.py so that numerical problems like the ZeroDivisionErrors and nans can potentially be caught well before actually running imSim.

@JoanneBogart JoanneBogart merged commit 4194896 into main Jun 17, 2024
1 check passed
@JoanneBogart JoanneBogart deleted the u/jrbogart/sso_ops4 branch June 18, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchiang87 jchiang87 jchiang87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoanneBogart @jchiang87