Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct calculation for star extinction #71

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

JoanneBogart
Copy link
Collaborator

Make use of ebv column from star sqlite db

@JoanneBogart
Copy link
Collaborator Author

JoanneBogart commented Oct 4, 2023

I did a comparison of a very small sample of old and new fluxes. I think it's reasonable. They're not identical but not very different:

old_tbl['lsst_flux_i'][:10]
<pyarrow.lib.ChunkedArray object at 0x7fabe4493150>
[
[
0.00006627533,
0.000029024348,
0.000032654632,
0.009009236,
0.000028461804,
0.000011157954,
0.000009312664,
0.000504227,
0.0000099784265,
0.000054448712
]
]
new_tbl['lsst_flux_i'][:10]
<pyarrow.lib.ChunkedArray object at 0x7fabe41e3d80>
[
[
0.00006609065,
0.000028960018,
0.000032573218,
0.00898783,
0.000028390612,
0.000011124053,
0.000009290497,
0.0005030877,
0.00000996649,
0.000054386965
]
]

@@ -1 +1 @@
__version__ = "1.6.0-rc2"
__version__ = "1.7.0-rc1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems premature.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mean to imply that this particular commit is going to be tagged, uploaded to PyPI, etc.
But there have been significant changes since the last actual release, not just patches. I probably should have advanced the minor version some time ago.

@JoanneBogart JoanneBogart merged commit 329e52a into main Oct 5, 2023
1 check passed
@JoanneBogart JoanneBogart deleted the u/jrbogart/star_ebv branch October 5, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants