work around for object types that don't have files for healpixels that have files for other object types #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t have files for other object types
JoanneBogart
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
This looks ok as a quick fix.
Ultimately something should be done about the elif block as well, but probably the right thing there is to eliminate it, after first replacing object_type with its parent if it has one at the beginning of the routine. In practice I doubt that block is ever executed. This can wait for another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing a problem when we use the SNANA test files + galaxy + star healpix files where files for some healpixels exist for the latter two, but not for the SNANA data. I've run into the same problem when I don't have the exact same set of hps for galaxies and point sources.