-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
U/jrbogart/gaia bypass #90
Merged
Merged
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
55eb809
starting gaia/fits work
JoanneBogart aa1f49a
first draft accessing FITS files directly
JoanneBogart 3c3940f
get rid of commented-out code
JoanneBogart 84371bc
get rid of iloc call; add config parameter for id prefix
JoanneBogart 32ef793
compress with correct syntax
JoanneBogart 95c2a41
fixes for PolygonalRegion
JoanneBogart 0cde69a
consistently use lsst utilities for geometry
JoanneBogart 5f8ee9a
Switch to using public compute_region_mask in shapes.py rather than i…
JoanneBogart 8986771
read htm level from config; other minor clean-up
JoanneBogart 0a8d0fa
Use logger rather than try..catch for abnormal but not fatal condition
JoanneBogart 17ff6fb
Fix issue with radians/degrees; make it possible to find data when ru…
JoanneBogart 3ee7ebf
do not expose import of git
JoanneBogart a57442d
Implement CI test for non-Butler access
JoanneBogart 988735a
Merge branch 'main' into u/jrbogart/gaia_bypass
JoanneBogart 27cad46
eliminate commented-out code
JoanneBogart 74f862c
address reviewer comment
JoanneBogart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
catalog_dir: ci_sample | ||
catalog_name: gaia_skyCatalog | ||
object_types: | ||
gaia_star: | ||
area_partition: | ||
level: 7 | ||
type: htm | ||
#butler_parameters: | ||
# collections: HSC/defaults | ||
# dstype: gaia_dr2_20200414 | ||
#data_file_type: butler_refcat | ||
id_prefix: gaia_dr2_ | ||
data_file_type: fits | ||
data_dir: ci_sample/repo/refcats/gaia_dr2_20200414 | ||
basename_template: gaia_dr2_20200414_(?P<htm>\d+)_refcats.fits | ||
sed_method: use_lut | ||
provenance: | ||
inputs: | ||
skyCatalogs_repo: | ||
git_branch: gaia_bypass | ||
git_hash: 3a87b5e825dbc8f692f9713b0b761a9ad6896364 | ||
git_status: | ||
- UNCOMMITTED_FILES | ||
versioning: | ||
code_version: 1.7.0-rc3 | ||
schema_version: 1.2.0 | ||
skycatalog_root: /sdf/home/j/jrb/rubin-user/skycatalog_root |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure
coord_ra
andcoord_dec
are in radians in the refcat files-- see the conversion inGaiaObject.__init__
. If so, these need to be converted to degrees when computing the masks below.