Issue 48499: Use preferred SecurityPolicyManager.savePolicy() variant #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-nicka
approved these changes
Aug 28, 2023
…alTask, pass in the User that started the pipeline job instead of User.getAdminServiceUser(). This user will have admin permissions in all the Panorama Public project folders.
vagisha
reviewed
Aug 29, 2023
| @@ -544,7 +544,7 @@ private void updatePermissions(User formSubmitter, ExperimentAnnotations targetE | |||
| assignPanoramaPublicSubmitterRole(newPolicy, log, targetExperiment.getSubmitterUser(), targetExperiment.getLabHeadUser(), | |||
| formSubmitter); // User that submitted the form. Can be different from the user selected as the data submitter | |||
|
|
|||
| SecurityPolicyManager.savePolicy(newPolicy); | |||
| SecurityPolicyManager.savePolicy(newPolicy, pipelineJobUser); | |||
There was a problem hiding this comment.
It should be OK to pass in the User that started the pipeline job instead of User.getAdminServiceUser(). I will revert the changes in my commit if tests fail due to this change.
vagisha
reviewed
Aug 29, 2023
| { | ||
| MutableSecurityPolicy newPolicy = new MutableSecurityPolicy(target, target.getPolicy()); | ||
| newPolicy.addRoleAssignment(reader, ReaderRole.class); | ||
| SecurityPolicyManager.savePolicy(newPolicy); | ||
| SecurityPolicyManager.savePolicy(newPolicy, pipelineJobUser); |
There was a problem hiding this comment.
Same here. It should be OK to pass in the User that started the pipeline job instead of User.getAdminServiceUser().
vagisha
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We're uneven in terms of the validation and auditing we do for saving SecurityPolicies and related updates, and want to be more consistent.
Related Pull Requests
Changes
savePolicyandcreateContainermethods that don't take a user, check permissions, or log for audit purposesUser.getAdminServiceUser()forsudolike scenarios or when we're doing an operation not initiated by a user, like bootstrapping the server