Make the "Public" column on the ExperimentAnnotations tableinfo an ExprColumn #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so that it can be sorted and filtered.
labkey-jeckels
approved these changes
Mar 18, 2024
| @@ -430,6 +385,19 @@ private ExprColumn getCatalogEntryCol() | |||
| return col; | |||
| } | |||
|
|
|||
| private ExprColumn getIsPublicCol() | |||
| { | |||
| SQLFragment isPublicColSql = new SQLFragment(" (SELECT CASE WHEN EXISTS (SELECT 1 FROM ") | |||
There was a problem hiding this comment.
This probably won't work if a container is inheriting permissions from its parent. That may not be relevant for this use case though.
There was a problem hiding this comment.
I should have noted that these containers do not inherit permissions from parent, so that is not a concern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The "Public" column on the ExperimentAnnotations table tells us if a Panorama Public dataset is public or not. We have been using the hasPermissions() method on the Container for this purpose. Make the column an ExprColumn so that it is filterable.