Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 51100: SignUp link from admin console shows up to the troubleshooter but throws 403 while accessing it #446

Closed
wants to merge 2 commits into from
Closed

Issue 51100: SignUp link from admin console shows up to the troubleshooter but throws 403 while accessing it #446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c725731
Issue 51100: SignUp link from admin console shows up to the troublesh…
vagisha Aug 21, 2024
2837f21
Only site admins should be able to see the admin console SignUp link.
vagisha Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion signup/src/org/labkey/signup/SignUpModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.labkey.api.module.DefaultModule;
import org.labkey.api.module.ModuleContext;
import org.labkey.api.security.UserManager;
import org.labkey.api.security.permissions.SiteAdminPermission;
import org.labkey.api.settings.AdminConsole;
import org.labkey.api.view.BaseWebPartFactory;
import org.labkey.api.view.JspView;
Expand Down Expand Up @@ -97,7 +98,7 @@ public void doStartup(ModuleContext moduleContext)
UserManager.addUserListener(new SignUpListener());

// Add a link in the admin console
AdminConsole.addLink(AdminConsole.SettingsLinkType.Configuration, "SignUp", SignUpController.getShowSignUpAdminUrl());
AdminConsole.addLink(AdminConsole.SettingsLinkType.Configuration, "SignUp", SignUpController.getShowSignUpAdminUrl(), SiteAdminPermission.class);
}

@Override
Expand Down