Issue 50179: Exceptions logged by Radeox are difficult to track back #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Radeox can spam our log files when it encounters non-fatal issues rendering wikis. In general, we want to capture a pointer back to the original source so that we can determine if there's a real problem. And in most cases, we want to relax the logging and simply render the original text even if Radeox can't interpret it.
Related Pull Requests
Changes
sourceDescriptionthrough to Radeox so we can point to the wiki, announcement, etc where the source came fromsourceDescriptionvia theRenderContextin error messages to the offending wiki