Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "compare" function in "RunDownBean.getTopLeaks". (#411) #452

Closed
wants to merge 1 commit into from
Closed

Fix "compare" function in "RunDownBean.getTopLeaks". (#411) #452

wants to merge 1 commit into from

Commits on Oct 23, 2024

  1. Fix "compare" function in "RunDownBean.getTopLeaks". (#411) 

    Rationale
The Skyline Nightly Test Results page displays an error if there are a lot of leaks reported because the "Compare" method implementation in "getTopLeaks" does not return consistent results. This was because it was mistakenly comparing the wrong set of numbers (comparing number of bytes leaked in one test to handle leaks in the other test) such that Compare(a, b) was not necessarily the opposite of Compare(b, a).
    @nickshulman @labkey-jeckels
    nickshulman authored and labkey-jeckels committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e45ba90 View commit details
    Browse the repository at this point in the history