Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

51284: Broken link found on mAb learn pages for LANL #659

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

labkey-klum
Copy link
Contributor

Rationale

related issue

The learn link was previously using a hard coded URL prefix for the details page. This has been updated to be a module property to allow non-code changes in the future.

Other Changes

  • Update the learn page label from LANLID to LANL ID
  • Simplify the initialization of module properties in the app. There wasn't a need to hold on to the various module properties as class variables. Consolidated repeated lines of code to simplify initialization.

@labkey-klum labkey-klum merged commit 68b27d9 into release24.9-SNAPSHOT Sep 17, 2024
1 check passed
@labkey-klum labkey-klum deleted the 24.9_fb_issue_51284 branch September 17, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants