Migrate more inline handlers (#169)

LabKey · Mar 8, 2024 · b942ceb · b942ceb
1 parent 627e074
commit b942ceb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/viscstudies/resources/views/migrateStudyDesigns.html b/viscstudies/resources/views/migrateStudyDesigns.html
@@ -1047,6 +1047,8 @@
 Ext4.onReady(function() {
     _migrateControl.getStudyDesigns();
     LABKEY.NavTrail.setTrail("Migrate Study Designs");
+    document.getElementById('migrateButton')['onclick'] = _migrateControl.doMigration;
+    document.getElementById('deleteButton')['onclick'] = _migrateControl.deleteAllRows;
 });
 
 </script>
@@ -1056,5 +1058,5 @@
 <div id="migrateList"><ul>
 
 </ul></div>
-<button id="migrateButton" onclick="_migrateControl.doMigration();" disabled>Migrate</button>
-<button id="deleteButton" onclick="_migrateControl.deleteAllRows();">Delete Migrated Data</button>
+<button id="migrateButton" disabled>Migrate</button>
+<button id="deleteButton">Delete Migrated Data</button>
diff --git a/viscstudies/webapp/viscstudies/study.js b/viscstudies/webapp/viscstudies/study.js
@@ -404,13 +404,13 @@ function initFacets()
         });
         tip.on("afterrender", function(t) {
             // Attach event handlers after HTML is rendered
-            document.getElementById('showAll_' + id)['click'] = function() { selectAll(id); return false;}
+            document.getElementById('showAll_' + id)['onclick'] = function() { selectAll(id); return false;}
             for (let i = 0; i < facet2.allOptions.length; i++)
             {
                 const id = facet2.id;
                 const idx = i;
-                document.getElementById(checkboxId(facet2, i))['click'] = function() { optionClicked(this, id, idx); };
-                document.getElementById('selectOnly_' + i)['click'] = function() { selectOnly(id, i); return false; }
+                document.getElementById(checkboxId(facet2, i))['onclick'] = function() { optionClicked(this, id, idx); };
+                document.getElementById('selectOnly_' + i)['onclick'] = function() { selectOnly(id, i); return false; }
             }
         });
     }