Skip to content

Commit

Permalink
Ensure S3 WebDAV paths are URL-encoded, fixing S3 tests (#6037)
Browse files Browse the repository at this point in the history
  • Loading branch information
labkey-jeckels authored Nov 11, 2024
1 parent 049a01d commit 5f41a16
Showing 1 changed file with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1399,15 +1399,7 @@ else if (assayFilesPath != null && URIUtil.isDescendant(assayFilesPath.toUri(),

if (relPath != null)
{
if (!isCloudRoot(container))
{
relPath = Path.parse(FilenameUtils.separatorsToUnix(relPath)).encode();
}
else
{
// Do not encode path from S3 folder. It is already encoded.
relPath = Path.parse(FilenameUtils.separatorsToUnix(relPath)).toString();
}
relPath = Path.parse(FilenameUtils.separatorsToUnix(relPath)).encode();

return switch (type)
{
Expand Down

0 comments on commit 5f41a16

Please sign in to comment.