Here is another idea for taming robot indexers #4016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
requested changes
Jan 13, 2023
| throw new UnauthorizedException(); | ||
| if (user.isGuest()) | ||
| throw new UnauthorizedException(); | ||
| if (this instanceof BaseViewAction<?> viewaction) |
There was a problem hiding this comment.
Do we expect this to be common? Won't crawlers always be guests?
Note there are a number of unit test failures when there's not a full HTTP request in progress: https://teamcity.labkey.org/buildConfiguration/LabkeyTrunk_BvtBPostgres/2225932?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&expandBuildTestsSection=true
There was a problem hiding this comment.
I was thinking about how we might use annotations as hints (or explicitly). I agree this is not functional...
Co-authored-by: Josh Eckels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
use rel=canonical to help ignore containerFilter variations
Related Pull Requests
Changes