Support additional context paths #5156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…directing, and for secondary static content
| // | ||
| // Source code recreated from a .class file by IntelliJ IDEA | ||
| // (powered by FernFlower decompiler) | ||
| // |
There was a problem hiding this comment.
Hah, IntelliJ had helpfully collapsed this section so I hadn't noticed it. I started with a redirector servlet that I wrote many years ago but I think the source code got lost in the SVN->GitHub migration. I still had the binaries in email though.
| { | ||
| if (!legacyContextPath.startsWith("/") || legacyContextPath.length() < 2) | ||
| { | ||
| throw new IllegalArgumentException("Invalid legacy context path: " + legacyContextPath); |
There was a problem hiding this comment.
Should this error message use the property name to make it easier to track down where the error is?
labkey-susanh
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Some server configurations have historically used non-root context paths, and/or deployed additional web apps for delivering static content.
Related Pull Requests
Changes
context.contextPathcontext.legacyContextPathwebapps.contextPathandwebapps.docBase