Fixed issue where certain subpackages were not getting populated in the getEvent response #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…//github.com/LabKey/snd into 23.11_fb_fixImproperHandlingOfEmptyEventData
RameshRapa
reviewed
Aug 9, 2024
| ? nextLevelEventDataSuperPkgs.get(eventData.getEventId()).values().stream().map(SuperPackage::getSuperPkgId).toList() | ||
| : new ArrayList<>(); | ||
|
|
||
| AtomicInteger emptyEventDataId = new AtomicInteger(0); |
There was a problem hiding this comment.
Can i please know if we are using any multithreads in here as i do see AtomicInteger? i checked in the sndManager code and i don't see any threads being used in this file.
There was a problem hiding this comment.
No, but in order to iterate an Integer object within a stream it needs to be Atomic
RameshRapa
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.