Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 48499: Use preferred SecurityPolicyManager.savePolicy() variant #61

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

labkey-jeckels
Copy link
Contributor

Rationale

We're uneven in terms of the validation and auditing we do for saving SecurityPolicies and related updates, and want to be more consistent.

Related Pull Requests

Changes

  • Let modules register ContainerSecurableResourceProviders instead of having Container know about them all
  • Remove the savePolicy and createContainer methods that don't take a user, check permissions, or log for audit purposes
  • Introduce User.getAdminServiceUser() for sudo like scenarios or when we're doing an operation not initiated by a user, like bootstrapping the server
  • Update callers

@labkey-jeckels labkey-jeckels requested a review from a team August 28, 2023 03:53
@labkey-jeckels labkey-jeckels merged commit 880a7e0 into develop Aug 29, 2023
2 checks passed
@labkey-jeckels labkey-jeckels deleted the fb_48499_savePolicyAudit branch August 29, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants