Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Fabric 1.20.1 #144

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Port to Fabric 1.20.1 #144

wants to merge 19 commits into from

Conversation

unilock
Copy link

@unilock unilock commented Jan 8, 2024

A work-in-progress PR to port RAT's Mischief to Fabric 1.20.1.

Current (known) issues:

  • The Rat Mask appears to have a missing texture when worn
  • The rat entity's right ear has z-fighting
  • Grown rats will render as baby rats if at least one baby rat is also on-screen
  • All rats will appear "aroused" if at least one aroused rat is also on-screen (is the same model / renderer instance being used for all rats???)
  • Identifier#withSuffix should be used in a few places
  • Rat items are not held at the correct offset

Notes:

  • Requiem support has been removed, as it hasn't been updated in a year :(
  • The dependency on MialeeMisc has been removed, as the mod is not yet fully updated for 1.20.1; instead, some classes from MialeeMisc have been copy / pasted into RAT's Mischief, and can be found in the mialeemisc package(s)
  • I'm probably forgetting some things lol

@NolanHewitt
Copy link

Thank you for working on this! Hopefully this can get checked and approved at some point.

@jjito1
Copy link

jjito1 commented Jun 5, 2024

Hopefully when Rat has some free time he'll look into this since this is well done! (Even if the whole rat's mischief 2.0 update was months ago.)

@ChaosDogG
Copy link

idk if this is due to the mods I'm using or if the game just crapped itself, but i crashed when trying to craft a Spy Rat-
crash-2024-09-20_12.57.36-client.txt

@Thinkseal
Copy link

Can you send the crash report using mclo.gs because it makes it easier to read and makes it so it doesn't reveal your computer's account's username

@ChaosDogG
Copy link

https://mclo.gs/aepULic
here u go!

@unilock
Copy link
Author

unilock commented Sep 22, 2024

@ChaosDogG Huh, I thought that was fixed with f679de7...

I'll look into it.

@ChaosDogG
Copy link

Maybe my modlist borked it

@ChaosDogG
Copy link

I also found out something to do with the adult rat model glitch, it only happens when a baby rat exists, though once all baby rats grow up, all models will be as expected

@axtrough
Copy link

hey. one question is it for fabric or quilt? and are you still working on this?

@ChaosDogG
Copy link

it's currently built on Quilt, but it should be moved to Fabric since RAT's going back there eventually

@ChaosDogG
Copy link

happy rat dances

@ChaosDogG
Copy link

uh....looks like the rendering is borked-
https://mclo.gs/lib7azF

@unilock
Copy link
Author

unilock commented Feb 2, 2025

@ChaosDogG "El & L's Dye Mod" modifies the DyeColor enum. This breaks many things, and I will not be going out of my way to support mods that violate the JVM spec :p

@ChaosDogG
Copy link

D'OH! i forgor abt the Rat Kids...

@unilock unilock changed the title Port to 1.20.1 Port to Fabric 1.20.1 Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants