Skip to content

Commit

Permalink
doc (Laerdal.Builder.targets): trivial doc-comment tweaks
Browse files Browse the repository at this point in the history
[skip ci]
  • Loading branch information
ksidirop-laerdal committed Oct 23, 2024
1 parent 4362eb2 commit 1f8169a
Show file tree
Hide file tree
Showing 6 changed files with 52 additions and 52 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>

<!-- these versions are getting replaced by the build script in one swift pass -->
<Version>1.0.1168.0</Version>
<FileVersion>1.0.1168.0</FileVersion>
<PackageVersion>1.0.1168.0</PackageVersion>
<AssemblyVersion>1.0.1168.0</AssemblyVersion>
<Version>1.0.1177.0</Version>
<FileVersion>1.0.1177.0</FileVersion>
<PackageVersion>1.0.1177.0</PackageVersion>
<AssemblyVersion>1.0.1177.0</AssemblyVersion>

<Title>$(PackageId)</Title>
<Owners>$(Authors)</Owners>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@
<AllowedReferenceRelatedFileExtensions>$(AllowedReferenceRelatedFileExtensions);.pdb</AllowedReferenceRelatedFileExtensions>

<!-- these versions are getting replaced by the build script in one swift pass -->
<Version>1.0.1168.0</Version>
<FileVersion>1.0.1168.0</FileVersion>
<PackageVersion>1.0.1168.0</PackageVersion>
<AssemblyVersion>1.0.1168.0</AssemblyVersion>
<Version>1.0.1177.0</Version>
<FileVersion>1.0.1177.0</FileVersion>
<PackageVersion>1.0.1177.0</PackageVersion>
<AssemblyVersion>1.0.1177.0</AssemblyVersion>

<Title>$(PackageId)</Title>
<Summary>McuMgr Bindings for MacCatalyst - MAUI ready</Summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@
<AllowedReferenceRelatedFileExtensions>$(AllowedReferenceRelatedFileExtensions);.pdb</AllowedReferenceRelatedFileExtensions>

<!-- these versions are getting replaced by the build script in one swift pass -->
<Version>1.0.1168.0</Version>
<FileVersion>1.0.1168.0</FileVersion>
<PackageVersion>1.0.1168.0</PackageVersion>
<AssemblyVersion>1.0.1168.0</AssemblyVersion>
<Version>1.0.1177.0</Version>
<FileVersion>1.0.1177.0</FileVersion>
<PackageVersion>1.0.1177.0</PackageVersion>
<AssemblyVersion>1.0.1177.0</AssemblyVersion>

<Title>$(PackageId)</Title>
<Summary>McuMgr C# Implementation (WIP)</Summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@
<AllowedReferenceRelatedFileExtensions>$(AllowedReferenceRelatedFileExtensions);.pdb</AllowedReferenceRelatedFileExtensions>

<!-- these versions are getting replaced by the build script in one swift pass -->
<Version>1.0.1168.0</Version>
<FileVersion>1.0.1168.0</FileVersion>
<PackageVersion>1.0.1168.0</PackageVersion>
<AssemblyVersion>1.0.1168.0</AssemblyVersion>
<Version>1.0.1177.0</Version>
<FileVersion>1.0.1177.0</FileVersion>
<PackageVersion>1.0.1177.0</PackageVersion>
<AssemblyVersion>1.0.1177.0</AssemblyVersion>

<Title>$(PackageId)</Title>
<Summary>McuMgr Bindings for iOS - MAUI ready</Summary>
Expand Down
62 changes: 31 additions & 31 deletions Laerdal.McuMgr/Laerdal.McuMgr.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>

<!-- these versions are getting replaced by the build script in one swift pass -->
<Version>1.0.1079.0</Version>
<FileVersion>1.0.1079.0</FileVersion>
<PackageVersion>1.0.1079.0</PackageVersion>
<AssemblyVersion>1.0.1079.0</AssemblyVersion>
<Version>1.0.1177.0</Version>
<FileVersion>1.0.1177.0</FileVersion>
<PackageVersion>1.0.1177.0</PackageVersion>
<AssemblyVersion>1.0.1177.0</AssemblyVersion>

<Title>$(PackageId)</Title>
<Owners>$(Authors)</Owners>
Expand Down Expand Up @@ -113,29 +113,29 @@
</ItemGroup>

<Target Name="PrintBuildInfo" BeforeTargets="CoreCompile">
<Message Importance="High" Text="OS: '$(OS)' "/>
<Message Importance="High" Text="Platform: '$(Platform)' "/>
<Message Importance="High" Text="PackageId: '$(PackageId)' "/>
<Message Importance="High" Text="Configuration: '$(Configuration)' "/>
<Message Importance="High" Text="PackageVersion: '$(PackageVersion)' "/>
<Message Importance="High" Text="TargetFramework: '$(TargetFramework)' "/>
<Message Importance="High" Text="DefineConstants: '$(DefineConstants)' "/>
<Message Importance="high" Text="MSBuildNodeCount: '$(MSBuildNodeCount)' "/>
<Message Importance="high" Text="Should_Skip_MacCatalyst: '$(Should_Skip_MacCatalyst)' "/>

<Message Importance="high" Text="TargetPlatformVersion: '$(TargetPlatformVersion)' "/>
<Message Importance="high" Text="SupportedOSPlatformVersion: '$(SupportedOSPlatformVersion)' "/>

<Message Importance="high" Text="IsNet8: '$(IsNet8)' "/>
<Message Importance="high" Text="IsNetX: '$(IsNetX)' "/>

<Message Importance="high" Text="IsNet8MacCatalyst: '$(IsNet8MacCatalyst)' "/>
<Message Importance="high" Text="IsNetXAndroid: '$(IsNetXAndroid)' "/>
<Message Importance="high" Text="IsNetXMacCatalyst: '$(IsNetXMacCatalyst)' "/>

<Message Importance="high" Text="IsIOS: '$(IsIOS)' "/>
<Message Importance="high" Text="IsAndroid: '$(IsAndroid)' "/>
<Message Importance="high" Text="IsAppleStuff: '$(IsAppleStuff)' "/>
<Message Importance="High" Text="OS: '$(OS)' "/>
<Message Importance="High" Text="Platform: '$(Platform)' "/>
<Message Importance="High" Text="PackageId: '$(PackageId)' "/>
<Message Importance="High" Text="Configuration: '$(Configuration)' "/>
<Message Importance="High" Text="PackageVersion: '$(PackageVersion)' "/>
<Message Importance="High" Text="TargetFramework: '$(TargetFramework)' "/>
<Message Importance="High" Text="DefineConstants: '$(DefineConstants)' "/>
<Message Importance="high" Text="MSBuildNodeCount: '$(MSBuildNodeCount)' "/>
<Message Importance="high" Text="Should_Skip_MacCatalyst: '$(Should_Skip_MacCatalyst)' "/>

<Message Importance="high" Text="TargetPlatformVersion: '$(TargetPlatformVersion)' "/>
<Message Importance="high" Text="SupportedOSPlatformVersion: '$(SupportedOSPlatformVersion)' "/>

<Message Importance="high" Text="IsNet8: '$(IsNet8)' "/>
<Message Importance="high" Text="IsNetX: '$(IsNetX)' "/>

<Message Importance="high" Text="IsNetXAndroid: '$(IsNetXAndroid)' "/>
<Message Importance="high" Text="IsNet8MacCatalyst: '$(IsNet8MacCatalyst)' "/>
<Message Importance="high" Text="IsNetXMacCatalyst: '$(IsNetXMacCatalyst)' "/>

<Message Importance="high" Text="IsIOS: '$(IsIOS)' "/>
<Message Importance="high" Text="IsAndroid: '$(IsAndroid)' "/>
<Message Importance="high" Text="IsAppleStuff: '$(IsAppleStuff)' "/>
</Target>

<!-- SHARED -->
Expand Down Expand Up @@ -167,21 +167,21 @@

<!-- ANDROID -->
<ItemGroup Condition=" '$(IsAndroid)' == 'true' ">
<PackageReference Include="Laerdal.McuMgr.Bindings.Android" Version="1.0.1079.0"/>
<PackageReference Include="Laerdal.McuMgr.Bindings.Android" Version="1.0.1177.0"/>
</ItemGroup>

<!-- IOS/MacCatalyst -->
<ItemGroup Condition=" '$(IsIOS)' == 'true' ">
<PackageReference Include="Laerdal.McuMgr.Bindings.iOS" Version="1.0.1079.0"/>
<PackageReference Include="Laerdal.McuMgr.Bindings.iOS" Version="1.0.1177.0"/>
</ItemGroup>

<ItemGroup Condition=" '$(IsNetXMacCatalyst)' == 'true' and '$(Should_Skip_MacCatalyst)' != 'true' ">
<PackageReference Include="Laerdal.McuMgr.Bindings.MacCatalyst" Version="1.0.1079.0"/>
<PackageReference Include="Laerdal.McuMgr.Bindings.MacCatalyst" Version="1.0.1177.0"/>
</ItemGroup>

<!-- NETSTANDARD -->
<ItemGroup Condition=" '$(IsNetStandard)' == 'true' ">
<PackageReference Include="Laerdal.McuMgr.Bindings.NetStandard" Version="1.0.1079.0"/>
<PackageReference Include="Laerdal.McuMgr.Bindings.NetStandard" Version="1.0.1177.0"/>
</ItemGroup>

</Project>
10 changes: 5 additions & 5 deletions Laerdal.Scripts/Laerdal.Builder.targets
Original file line number Diff line number Diff line change
Expand Up @@ -243,17 +243,17 @@
<MSBuild Projects="$(Laerdal_McuMgrBindings_ProjectFile_Android)"
Properties="$(_Laerdal_Build_Parameters);Laerdal_Bindings_Android___DotnetTargetPlatformVersion=$(Laerdal_Bindings_Android___DotnetTargetPlatformVersion);BuildingProject=true;Skip_CompileMcuMgrLaerdalWrapper=true;SourceRoot=$(Laerdal_RootDirectory_Folderpath)/Laerdal.McuMgr.Bindings.Android/;" Targets="Build"/>

<!-- its absolute vital to call this targets first explicitly and separately from the main build otherwise the -->
<!-- resulting nugets will be poisoned and will not work in maui apps at all due to missing native symbols -->
<!-- [warning] its absolute vital to call this targets first explicitly and separately from the main build otherwise the -->
<!-- [warning] resulting nugets will be poisoned and will not work in maui apps at all due to missing native symbols -->
<MSBuild Projects="$(Laerdal_McuMgrBindings_ProjectFile_iOS)" Targets="EnsureFrameworkFolderIsCreated"/>
<MSBuild Projects="$(Laerdal_McuMgrBindings_ProjectFile_iOS)"
Properties="$(_Laerdal_Build_Parameters);Laerdal_Bindings_iOS___DotnetTargetPlatformVersion=$(Laerdal_Bindings_iOS___DotnetTargetPlatformVersion);Laerdal_Bindings_iOS___Xcode_Ide_Dev_Path=$(Laerdal_Bindings_iOS___Xcode_Ide_Dev_Path);Laerdal_Bindings_iOS___Sdk_Version=$(Laerdal_Bindings_iOS___Sdk_Version);SourceRoot=$(Laerdal_RootDirectory_Folderpath)/Laerdal.McuMgr.Bindings.iOS/;" Targets="Restore;Rebuild"/>

<!-- its absolute vital to call this targets first explicitly and separately from the main build otherwise the -->
<!-- resulting nugets will be poisoned and will not work in maui apps at all due to missing native symbols -->
<!-- [warning] its absolute vital to call this targets first explicitly and separately from the main build otherwise the -->
<!-- [warning] resulting nugets will be poisoned and will not work in maui apps at all due to missing native symbols -->
<MSBuild Projects="$(Laerdal_McuMgrBindings_ProjectFile_MacCatalyst)" Targets="EnsureFrameworkFolderIsCreated" Condition=" '$(Should_Skip_MacCatalyst)' != 'true' "/>
<MSBuild Targets="Restore;Rebuild" Condition=" '$(Should_Skip_MacCatalyst)' != 'true' "
Projects="$(Laerdal_McuMgrBindings_ProjectFile_MacCatalyst)"
Projects="$(Laerdal_McuMgrBindings_ProjectFile_MacCatalyst)"
Properties="$(_Laerdal_Build_Parameters);Laerdal_Bindings_MacCatalyst___DotnetTargetPlatformVersion=$(Laerdal_Bindings_MacCatalyst___DotnetTargetPlatformVersion);Laerdal_Bindings_MacCatalyst___Xcode_Ide_Dev_Path=$(Laerdal_Bindings_MacCatalyst___Xcode_Ide_Dev_Path);Laerdal_Bindings_MacCatalyst___Sdk_Version=$(Laerdal_Bindings_MacCatalyst___Sdk_Version);SourceRoot=$(Laerdal_RootDirectory_Folderpath)/Laerdal.McuMgr.Bindings.MacCatalyst/;" />

<!-- notice that we are actually rebuilding mcumgr merely building the project doesnt really cut it -->
Expand Down

0 comments on commit 1f8169a

Please sign in to comment.