Skip to content

Commit

Permalink
fix (Laerdal.McuMgr.csproj): re-enable mac-catalyst builds considerin…
Browse files Browse the repository at this point in the history
…g that they work on github
  • Loading branch information
ksidirop-laerdal committed Apr 5, 2024
1 parent 0beb49f commit 41e00ed
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Laerdal.McuMgr/Laerdal.McuMgr.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<TargetFrameworks>$(TargetFrameworks)netstandard2.1;</TargetFrameworks>
<TargetFrameworks>$(TargetFrameworks)net8.0-android;</TargetFrameworks>
<TargetFrameworks Condition=" '$(IsOSX)' == 'true' ">$(TargetFrameworks)net8.0-ios11;</TargetFrameworks>
<!-- <TargetFrameworks Condition=" '$(IsOSX)' == 'true' and '$(ShouldSkipMacCatalyst)' != 'true' ">$(TargetFrameworks)net8.0-maccatalyst</TargetFrameworks> -->
<TargetFrameworks Condition=" '$(IsOSX)' == 'true' and '$(ShouldSkipMacCatalyst)' != 'true' ">$(TargetFrameworks)net8.0-maccatalyst</TargetFrameworks>

<IsNet8 Condition=" '$(TargetFramework.ToLower().StartsWith(net8))' == 'true' ">true</IsNet8>
<IsNet8IOS Condition=" '$(TargetFramework.ToLower().StartsWith(net8.0-ios))' == 'true' ">true</IsNet8IOS>
Expand Down
2 changes: 1 addition & 1 deletion Laerdal.Scripts/Laerdal.SetupBuildEnvironment.sh
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ echo "** XCode Installations:"

ls -ld /Applications/Xcode* || exit 90

sudo xcode-select -s /Applications/Xcode_14.3.app/Contents/Developer # todo experiment with /Applications/Xcode_15.2.app and see if it works
sudo xcode-select -s /Applications/Xcode_15.2.app/Contents/Developer # todo experiment with /Applications/Xcode_15.2.app and see if it works
declare exitCode=$?
if [ $exitCode != 0 ]; then
echo "##vso[task.logissue type=error]Failed to apply 'xcode-select'."
Expand Down

0 comments on commit 41e00ed

Please sign in to comment.