perf (iOS/all operations): we now launch logging and progress% callba…

…cks in the background so that the file-uploading/downloading aspects will be unimpeded [skip ci]
Laerdal · Jan 17, 2025 · 435b193 · 435b193
1 parent fcbec31
commit 435b193
Show file tree

Hide file tree

Showing 8 changed files with 33 additions and 21 deletions.
diff --git a/Laerdal.McuMgr.Bindings.Android/Laerdal.McuMgr.Bindings.Android.csproj b/Laerdal.McuMgr.Bindings.Android/Laerdal.McuMgr.Bindings.Android.csproj
@@ -62,7 +62,7 @@
         <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
 
         <!-- these versions are getting replaced by the build script in one swift pass -->
-        <Version>1.0.1225.0</Version>
+        <Version>1.0.1230.0</Version>
 
         <FileVersion>$(Version)</FileVersion>
         <PackageVersion>$(Version)</PackageVersion>

diff --git a/Laerdal.McuMgr.Bindings.MacCatalyst/Laerdal.McuMgr.Bindings.MacCatalyst.csproj b/Laerdal.McuMgr.Bindings.MacCatalyst/Laerdal.McuMgr.Bindings.MacCatalyst.csproj
@@ -77,7 +77,7 @@
         <AllowedReferenceRelatedFileExtensions>$(AllowedReferenceRelatedFileExtensions);.pdb</AllowedReferenceRelatedFileExtensions>
 
         <!-- these versions are getting replaced by the build script in one swift pass -->
-        <Version>1.0.1225.0</Version>
+        <Version>1.0.1230.0</Version>
 
         <FileVersion>$(Version)</FileVersion>
         <PackageVersion>$(Version)</PackageVersion>

diff --git a/...ings.MacCatalystAndIos.Native/McuMgrBindingsiOS/McuMgrBindingsiOS/IOSFileDownloader.swift b/...ings.MacCatalystAndIos.Native/McuMgrBindingsiOS/McuMgrBindingsiOS/IOSFileDownloader.swift
@@ -192,7 +192,9 @@ public class IOSFileDownloader: NSObject {
 
     //@objc   dont
     private func logMessageAdvertisement(_ message: String, _ category: String, _ level: String) {
-        _listener.logMessageAdvertisement(message, category, level, _remoteFilePathSanitized)
+        DispatchQueue.global(qos: .background).async { //fire and forget to boost performance
+            self._listener.logMessageAdvertisement(message, category, level, self._remoteFilePathSanitized)
+        }
     }
 
     //@objc   dont
@@ -218,7 +220,9 @@ public class IOSFileDownloader: NSObject {
             _ progressPercentage: Int,
             _ averageThroughput: Float32
     ) {
-        _listener.fileDownloadProgressPercentageAndDataThroughputChangedAdvertisement(progressPercentage, averageThroughput)
+        DispatchQueue.global(qos: .background).async { //fire and forget to boost performance
+            self._listener.fileDownloadProgressPercentageAndDataThroughputChangedAdvertisement(progressPercentage, averageThroughput)
+        }
     }
 
     //@objc   dont

diff --git a/...ndings.MacCatalystAndIos.Native/McuMgrBindingsiOS/McuMgrBindingsiOS/IOSFileUploader.swift b/...ndings.MacCatalystAndIos.Native/McuMgrBindingsiOS/McuMgrBindingsiOS/IOSFileUploader.swift
@@ -258,7 +258,9 @@ public class IOSFileUploader: NSObject {
 
     //@objc   dont
     private func logMessageAdvertisement(_ message: String, _ category: String, _ level: String) {
-        _listener.logMessageAdvertisement(message, category, level, _remoteFilePathSanitized)
+        DispatchQueue.global(qos: .background).async { //fire and forget to boost performance
+            self._listener.logMessageAdvertisement(message, category, level, self._remoteFilePathSanitized)
+        }
     }
 
     //@objc   dont
@@ -294,10 +296,12 @@ public class IOSFileUploader: NSObject {
             _ progressPercentage: Int,
             _ averageThroughput: Float32
     ) {
-        _listener.fileUploadProgressPercentageAndDataThroughputChangedAdvertisement(
-                progressPercentage,
-                averageThroughput
-        )
+        DispatchQueue.global(qos: .background).async { //fire and forget to boost performance
+            self._listener.fileUploadProgressPercentageAndDataThroughputChangedAdvertisement(
+                    progressPercentage,
+                    averageThroughput
+            )
+        }
     }
 
     private func setState(_ newState: EIOSFileUploaderState) {

diff --git a/...s.MacCatalystAndIos.Native/McuMgrBindingsiOS/McuMgrBindingsiOS/IOSFirmwareInstaller.swift b/...s.MacCatalystAndIos.Native/McuMgrBindingsiOS/McuMgrBindingsiOS/IOSFirmwareInstaller.swift
@@ -215,7 +215,9 @@ public class IOSFirmwareInstaller: NSObject {
     //@objc   dont
 
     private func logMessageAdvertisement(_ message: String, _ category: String, _ level: String) {
-        _listener.logMessageAdvertisement(message, category, level);
+        DispatchQueue.global(qos: .background).async { //fire and forget to boost performance
+            self._listener.logMessageAdvertisement(message, category, level)
+        }
     }
 
     //@objc   dont
@@ -245,7 +247,9 @@ public class IOSFirmwareInstaller: NSObject {
             _ progressPercentage: Int,
             _ averageThroughput: Float32
     ) {
-        _listener.firmwareUploadProgressPercentageAndDataThroughputChangedAdvertisement(progressPercentage, averageThroughput)
+        DispatchQueue.global(qos: .background).async { //fire and forget to boost performance
+            self._listener.firmwareUploadProgressPercentageAndDataThroughputChangedAdvertisement(progressPercentage, averageThroughput)
+        }
     }
 
     private func setState(_ newState: EIOSFirmwareInstallationState) {
@@ -371,9 +375,9 @@ extension IOSFirmwareInstaller: McuMgrLogDelegate {
             atLevel level: iOSMcuManagerLibrary.McuMgrLogLevel
     ) {
         logMessageAdvertisement(
-                msg,
-                category.rawValue,
-                level.name
+            msg,
+            category.rawValue,
+            level.name
         )
     }
 }
diff --git a/Laerdal.McuMgr.Bindings.NetStandard/Laerdal.McuMgr.Bindings.NetStandard.csproj b/Laerdal.McuMgr.Bindings.NetStandard/Laerdal.McuMgr.Bindings.NetStandard.csproj
@@ -37,7 +37,7 @@
         <AllowedReferenceRelatedFileExtensions>$(AllowedReferenceRelatedFileExtensions);.pdb</AllowedReferenceRelatedFileExtensions>
 
         <!-- these versions are getting replaced by the build script in one swift pass --> 
-        <Version>1.0.1225.0</Version>
+        <Version>1.0.1230.0</Version>
 
         <FileVersion>$(Version)</FileVersion>
         <PackageVersion>$(Version)</PackageVersion>

diff --git a/Laerdal.McuMgr.Bindings.iOS/Laerdal.McuMgr.Bindings.iOS.csproj b/Laerdal.McuMgr.Bindings.iOS/Laerdal.McuMgr.Bindings.iOS.csproj
@@ -74,7 +74,7 @@
         <AllowedReferenceRelatedFileExtensions>$(AllowedReferenceRelatedFileExtensions);.pdb</AllowedReferenceRelatedFileExtensions>
 
         <!-- these versions are getting replaced by the build script in one swift pass -->
-        <Version>1.0.1225.0</Version>
+        <Version>1.0.1230.0</Version>
 
         <FileVersion>$(Version)</FileVersion>
         <PackageVersion>$(Version)</PackageVersion>

diff --git a/Laerdal.McuMgr/Laerdal.McuMgr.csproj b/Laerdal.McuMgr/Laerdal.McuMgr.csproj
@@ -76,7 +76,7 @@
         <AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
 
         <!-- these versions are getting replaced by the build script in one swift pass -->
-        <Version>1.0.1225.0</Version>
+        <Version>1.0.1230.0</Version>
 
         <FileVersion>$(Version)</FileVersion>
         <PackageVersion>$(Version)</PackageVersion>
@@ -176,22 +176,22 @@
 
     <!-- ANDROID -->
     <ItemGroup Condition=" '$(IsAndroid)' == 'true' ">
-        <PackageReference Include="Laerdal.McuMgr.Bindings.Android" Version="1.0.1225.0"/>
+        <PackageReference Include="Laerdal.McuMgr.Bindings.Android" Version="1.0.1230.0"/>
     </ItemGroup>
 
     <!-- IOS -->
     <ItemGroup Condition=" '$(IsIOS)' == 'true' ">
-        <PackageReference Include="Laerdal.McuMgr.Bindings.iOS" Version="1.0.1225.0"/>
+        <PackageReference Include="Laerdal.McuMgr.Bindings.iOS" Version="1.0.1230.0"/>
     </ItemGroup>
 
     <!-- MACCATALYST -->
     <ItemGroup Condition=" '$(IsNetXMacCatalyst)' == 'true' and '$(Should_Skip_MacCatalyst)' != 'true' ">
-        <PackageReference Include="Laerdal.McuMgr.Bindings.MacCatalyst" Version="1.0.1225.0"/>
+        <PackageReference Include="Laerdal.McuMgr.Bindings.MacCatalyst" Version="1.0.1230.0"/>
     </ItemGroup>
 
     <!-- NETSTANDARD -->
     <ItemGroup Condition=" '$(IsDudNet8_0)' == 'true' ">
-        <PackageReference Include="Laerdal.McuMgr.Bindings.NetStandard" Version="1.0.1225.0"/>
+        <PackageReference Include="Laerdal.McuMgr.Bindings.NetStandard" Version="1.0.1230.0"/>
     </ItemGroup>
 
 </Project>