perf (iOS/all operations): we now launch logging and progress% callba…

…cks in the background so that the file-uploading/downloading aspects will be unimpeded
Laerdal · Jan 17, 2025 · ca8a335 · ca8a335
1 parent fcbec31
commit ca8a335
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 12 deletions.
diff --git a/...ings.MacCatalystAndIos.Native/McuMgrBindingsiOS/McuMgrBindingsiOS/IOSFileDownloader.swift b/...ings.MacCatalystAndIos.Native/McuMgrBindingsiOS/McuMgrBindingsiOS/IOSFileDownloader.swift
@@ -192,7 +192,9 @@ public class IOSFileDownloader: NSObject {
 
     //@objc   dont
     private func logMessageAdvertisement(_ message: String, _ category: String, _ level: String) {
-        _listener.logMessageAdvertisement(message, category, level, _remoteFilePathSanitized)
+        DispatchQueue.global(qos: .background).async { //fire and forget to boost performance
+            self._listener.logMessageAdvertisement(message, category, level, self._remoteFilePathSanitized)
+        }
     }
 
     //@objc   dont
@@ -218,7 +220,9 @@ public class IOSFileDownloader: NSObject {
             _ progressPercentage: Int,
             _ averageThroughput: Float32
     ) {
-        _listener.fileDownloadProgressPercentageAndDataThroughputChangedAdvertisement(progressPercentage, averageThroughput)
+        DispatchQueue.global(qos: .background).async { //fire and forget to boost performance
+            self._listener.fileDownloadProgressPercentageAndDataThroughputChangedAdvertisement(progressPercentage, averageThroughput)
+        }
     }
 
     //@objc   dont

diff --git a/...ndings.MacCatalystAndIos.Native/McuMgrBindingsiOS/McuMgrBindingsiOS/IOSFileUploader.swift b/...ndings.MacCatalystAndIos.Native/McuMgrBindingsiOS/McuMgrBindingsiOS/IOSFileUploader.swift
@@ -258,7 +258,9 @@ public class IOSFileUploader: NSObject {
 
     //@objc   dont
     private func logMessageAdvertisement(_ message: String, _ category: String, _ level: String) {
-        _listener.logMessageAdvertisement(message, category, level, _remoteFilePathSanitized)
+        DispatchQueue.global(qos: .background).async { //fire and forget to boost performance
+            self._listener.logMessageAdvertisement(message, category, level, self._remoteFilePathSanitized)
+        }
     }
 
     //@objc   dont
@@ -294,10 +296,12 @@ public class IOSFileUploader: NSObject {
             _ progressPercentage: Int,
             _ averageThroughput: Float32
     ) {
-        _listener.fileUploadProgressPercentageAndDataThroughputChangedAdvertisement(
-                progressPercentage,
-                averageThroughput
-        )
+        DispatchQueue.global(qos: .background).async { //fire and forget to boost performance
+            self._listener.fileUploadProgressPercentageAndDataThroughputChangedAdvertisement(
+                    progressPercentage,
+                    averageThroughput
+            )
+        }
     }
 
     private func setState(_ newState: EIOSFileUploaderState) {

diff --git a/...s.MacCatalystAndIos.Native/McuMgrBindingsiOS/McuMgrBindingsiOS/IOSFirmwareInstaller.swift b/...s.MacCatalystAndIos.Native/McuMgrBindingsiOS/McuMgrBindingsiOS/IOSFirmwareInstaller.swift
@@ -215,7 +215,9 @@ public class IOSFirmwareInstaller: NSObject {
     //@objc   dont
 
     private func logMessageAdvertisement(_ message: String, _ category: String, _ level: String) {
-        _listener.logMessageAdvertisement(message, category, level);
+        DispatchQueue.global(qos: .background).async { //fire and forget to boost performance
+            self._listener.logMessageAdvertisement(message, category, level)
+        }
     }
 
     //@objc   dont
@@ -245,7 +247,9 @@ public class IOSFirmwareInstaller: NSObject {
             _ progressPercentage: Int,
             _ averageThroughput: Float32
     ) {
-        _listener.firmwareUploadProgressPercentageAndDataThroughputChangedAdvertisement(progressPercentage, averageThroughput)
+        DispatchQueue.global(qos: .background).async { //fire and forget to boost performance
+            self._listener.firmwareUploadProgressPercentageAndDataThroughputChangedAdvertisement(progressPercentage, averageThroughput)
+        }
     }
 
     private func setState(_ newState: EIOSFirmwareInstallationState) {
@@ -371,9 +375,9 @@ extension IOSFirmwareInstaller: McuMgrLogDelegate {
             atLevel level: iOSMcuManagerLibrary.McuMgrLogLevel
     ) {
         logMessageAdvertisement(
-                msg,
-                category.rawValue,
-                level.name
+            msg,
+            category.rawValue,
+            level.name
         )
     }
 }