[MAN-369] laerdal mcu mgr new releases do not get auto announced as intended when merging to develop master main #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_MacCatalyst [skip ci]
… by dropping curl completely and using 'gh' cli-util instead to create new releases
…uild=true if the build takes place in a CICD environment
… point of view and from sharpie's point of view
… in the logs the exact sharpie command used to generate the api-definition-and-struct .cs files
…BUILD_TARGET_SDK_VERSION trivial rename for the sake of clarity
…BUILD_TARGET_SDK_VERSION=17.2 before invoking Laerdal.Mac.CompileAndGenerateFatLibs.sh to force xcode build and sharpie to agree on what the latest iphoneios sdk version is
old was: we would leave this env-var empty and this would in turn cause the ci to fail on github because the xcode-build would use xcode15.2 with sdk=iphoneos17.2 but
sharpie would assume the latest sdk to be iphoneos18.0 from xcode16.0 causing errors upon trying to generate the .cs files
…RGET_SDK_VERSION is specified then we set it to a reasonable default for iphoneos (17.2) and maccatalyst (14.2) [skip ci]
…es for the sake of clarity
…entions in the exception handling logic
…ileNotFoundException_GivenNonExistentFilepath.cs): fix a bug which was causing the test to fail sometimes due to a racing condition between 'throw DownloadErroredOutRemoteFileNotFoundException' and state-changed-event->Error
…changed-events before any success/fatal-error termination-events (which is the actual behaviour of all the mechanisms we have in practice)
…lize XCODEBUILD_TARGET_SDK_VERSION
…vent instead of state-changed to set the completion
this should address the issues we're seeing with the failing test
SingleFileUploadAsync_ShouldCompleteSuccessfully_GivenGreenNativeFileUploader()
…ke of readability
ksidirop-laerdal
deleted the
MAN-369-laerdal-mcu-mgr-new-releases-do-not-get-auto-announced-as-intended-when-merging-to-develop-master-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also address:
[MAN-370] [Laerdal.McuMgr] Test-Suite: Various test cases fail due to racing-conditions between the state-changed-event-firing and the final events for successful completion/exception throwing
[MAN-371] [Laerdal.McuMgr / iOS] GitHub CI: Our pipelines broke on the iOS / MacCatalyst side due to sharpie picking the latest iphoneos SDK in general instead of the latest iphoneos supported by xcode 15.2