-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Run the worker from source
section to README
#137
base: main
Are you sure you want to change the base?
Conversation
e3ace0a
to
5be53cd
Compare
README.md
Outdated
3. Update the system maximum stack size to unlimited | ||
|
||
```sh | ||
ulimit -s unlimited |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@delehef any blockers on this ? @silathdiir doesn't it impact performance ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't it impact performance ?
I think it's possible and may be unsafe. I just updated to a limited value 100000000
(and mark unlimited
as not recomended) in commit a0282f5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any blockers on this ?
AFAIK, the only issue is that accidental infinite recursion would blow up the whole memory instead of early killing the faulty program, so I don't think that enabled unlimited stack in this context a big risk.
|
||
```sh | ||
RUST_BACKTRACE=1 RUST_LOG=debug cargo run --release --bin lgn-worker -- --config YOUR_CONFIG.toml | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe lets also add a default config, and a link to the public params that work with this version of the worker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the latest public parameters URL to lgn-worker/src/config/default.toml
(but I don't fix the gateway URL) in commit d74088b.
I have a section of Update the worker configuration, I think maybe the gateway URL should be set at this step. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me. @kaisbaccour , just double checking, is the URL https://pub-a894572689a54c008859f232868fc67d.r2.dev
the one to make public?
Run the worker from source
section to READMERun the worker from source
section to README
No description provided.