fix: add mp2 version as a path to the download params URL #140
+95
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silathdiir
requested review from
hackaugusto,
delehef,
nikkolasg and
kaisbaccour
delehef
requested changes
Jan 20, 2025
lgn-worker/src/config/mod.rs
Outdated
| @@ -21,8 +22,9 @@ pub(crate) struct Config | |||
| #[derive(Deserialize, Debug, Clone, PartialEq)] | |||
| pub(crate) struct PublicParamsConfig | |||
| { | |||
| pub(crate) url: String, | |||
| pub(crate) checksum_url: String, | |||
| // We will build the URLs with the mp2 version in functions | |||
There was a problem hiding this comment.
Should these two be renamed e.g. param_files_root_url and checksum_root_url, as we will build them later?
There was a problem hiding this comment.
I rename url to params_root_url and delete checksum_url (since it points to one file) in commit 17fd620. I add a constant PARAMS_CHECKSUM_FILENAME for the checksum hash filename which should also be used for params generation in DQ.
| mp2_common = { git = "https://github.com/Lagrange-Labs/mapreduce-plonky2.git", branch = "lag-375-add-mp2-git-version" } | ||
| mp2_v1 = { git = "https://github.com/Lagrange-Labs/mapreduce-plonky2.git", branch = "lag-375-add-mp2-git-version" } | ||
| parsil = { git = "https://github.com/Lagrange-Labs/mapreduce-plonky2.git", branch = "lag-375-add-mp2-git-version" } | ||
| verifiable-db = { git = "https://github.com/Lagrange-Labs/mapreduce-plonky2.git", branch = "lag-375-add-mp2-git-version" } |
There was a problem hiding this comment.
Let us not forget to remove that before merging when the MR2 PR will have been merged :)
delehef
approved these changes
Jan 20, 2025
silathdiir
changed the title
|
It could work on bromberg, but need to test more on |
kaisbaccour
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with this discussion
Related with PRs:
Lagrange-Labs/mapreduce-plonky2#434
https://github.com/Lagrange-Labs/distributed-query/pull/1025
TODO