Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: packet & cache #36

Merged
merged 5 commits into from
May 8, 2024
Merged

optimize: packet & cache #36

merged 5 commits into from
May 8, 2024

Conversation

fumiama
Copy link
Member

@fumiama fumiama commented May 8, 2024

  • 优化代码结构
    • 移除所有(bool, error)格式的返回,优化返回值处理
    • 将一些无需公开的函数首字母设为小写
    • 其它代码风格优化
  • 泛型化packet/oidb返回处理
  • 泛型化cache并应用syncx.Map实现更细粒度缓存读写锁

@fumiama
Copy link
Member Author

fumiama commented May 8, 2024

全部代码至此已经都过一遍了,频繁PR也将告一段落,等项目再推进一段时间后会视情况PR和gocq对接相关的代码优化,目前先躺了。

@Redmomn Redmomn merged commit beb6239 into LagrangeDev:master May 8, 2024
2 checks passed
@Redmomn
Copy link
Collaborator

Redmomn commented May 8, 2024

太强了🤩

@fumiama
Copy link
Member Author

fumiama commented May 8, 2024

优化强迫症犯了😭😭如果优化的这些代码引入了什么新bug,到时候直接 @ 我。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants