New "Asking for feedback" page #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyPorter
reviewed
Jan 5, 2023
AndyPorter
reviewed
Jan 5, 2023
AndyPorter
requested changes
Jan 5, 2023
ahosgood
changed the title
ahosgood
requested review from
matthew-shaw,
Erintregunna,
accessibilitydesign and
avflay
as code owners
accessibilitydesign
approved these changes
Jan 6, 2023
ahosgood
commented
Jan 6, 2023
|
|
||
| Off-the-shelf surveys and form products, for example Microsoft forms and Google forms, are often used for collecting information. | ||
|
|
||
| The laws that apply to feedback pages we code ourselves apply equally to those we choose to include from third parties. As the operator of the service, we are responsible for those third parties compliance with the law. For example the data protection laws and the Equality Act 2010. |
There was a problem hiding this comment.
Not sure I understand what this paragraph is trying to say. If we use a third party tool (e.g. Google Analytics) then it isn't our responsibility to ensure their compliance.
ahosgood
commented
Jan 6, 2023
|
|
||
| The feedback form must be accessibility tested as part of the accessibility statement. | ||
|
|
||
| ## Accessibility and inclusivity |
There was a problem hiding this comment.
Is this somewhat a duplication of what is in the Accessibility section of the Design System?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38