docker run: prevent concurrent unpacking of nar files

LangStream · Jan 26, 2024 · 1c43455 · 1c43455
1 parent 4d50128
commit 1c43455
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/langstream-core/src/main/java/ai/langstream/impl/nar/NarFileHandler.java b/langstream-core/src/main/java/ai/langstream/impl/nar/NarFileHandler.java
@@ -210,6 +210,18 @@ public synchronized void scan() throws Exception {
 
     public void handleNarFile(Path narFile) throws Exception {
         String filename = narFile.getFileName().toString();
+        if (packages.containsKey(filename)) {
+            log.error(
+                    "NarFileHandler ID: {} The package {} has already been processed",
+                    System.identityHashCode(this),
+                    filename);
+            log.error(
+                    "NarFileHandler ID: {} Current packages: {}",
+                    System.identityHashCode(this),
+                    packages.keySet());
+            throw new IllegalStateException(
+                    "The package " + filename + " has already been processed");
+        }
 
         // first of all we look for an index file
         try (ZipFile zipFile = new ZipFile(narFile.toFile())) {

diff --git a/...untime/langstream-runtime-impl/src/main/java/ai/langstream/runtime/agent/AgentRunner.java b/...untime/langstream-runtime-impl/src/main/java/ai/langstream/runtime/agent/AgentRunner.java
@@ -160,16 +160,19 @@ public void run(
         log.info("Code directory {}", codeDirectory);
         log.info("Base persistent state directory {}", basePersistentStateDirectory);
 
+        boolean sharingNarFileHandler = sharedNarFileHandler != null;
         List<URL> customLibClasspath = buildCustomLibClasspath(codeDirectory);
         NarFileHandler narFileHandler =
-                sharedNarFileHandler != null
+                sharingNarFileHandler
                         ? sharedNarFileHandler
                         : new NarFileHandler(
                                 agentsDirectory,
                                 customLibClasspath,
                                 Thread.currentThread().getContextClassLoader());
         try {
-            narFileHandler.scan();
+            if (!sharingNarFileHandler) {
+                narFileHandler.scan();
+            }
 
             TopicConnectionsRuntimeRegistry topicConnectionsRuntimeRegistry =
                     new TopicConnectionsRuntimeRegistry();
@@ -208,7 +211,7 @@ public void run(
                 topicConnectionsRuntimeWithClassloader.close();
             }
         } finally {
-            if (sharedNarFileHandler == null) {
+            if (!sharingNarFileHandler) {
                 narFileHandler.close();
             }
         }