Address bypass by navigation to text-fragments links #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naugtur
reviewed
Sep 4, 2024
| } from './native.mjs'; | ||
| import {distraction, unselectable} from './element.mjs'; | ||
| import {getShadow} from './shadow.mjs'; | ||
|
|
||
| // text-fragments links can be abused to leak shadow internals - block in-app redirection to them | ||
| navigation.addEventListener('navigate', event => { |
There was a problem hiding this comment.
(could) maybe add an option to opt-out, starting with unsafe ?
There was a problem hiding this comment.
It's very safe actually (taken from #38 (comment)):
An app should never have a legitimate reason to redirect to such a link within itself, so blocking in-app only attempts should correctly focus on attack attempts only.
There was a problem hiding this comment.
I want to create software that's as less dependent on configuration as possible, meaning I'd support configuration only when it's truly necessary
naugtur
approved these changes
Sep 4, 2024
weizman
added a commit
that referenced
this pull request
Sep 18, 2024
weizman
added a commit
that referenced
this pull request
Sep 18, 2024
Closed
|
The Navigation API used for this mitigation is not supported by Safari and Firefox, so this change seems to throw an error in both browsers. |
Merged
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jan 29, 2025
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context @ #35
The protection added is blocking redirection attempts to text-fragments based links that take place within the app itself.
Determining a link is text-fragments based is very straight forward according to the spec.
An app should never have a legitimate reason to redirect to such a link within itself, so blocking in-app only attempts should correctly focus on attack attempts only.
Based on text-fragments based links spec @ https://developer.mozilla.org/en-US/docs/Web/Text_fragments