Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip unattached shadows #161

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Skip unattached shadows #161

merged 3 commits into from
Oct 28, 2024

Conversation

weizman
Copy link
Member

@weizman weizman commented Oct 27, 2024 •
edited
Loading

The shadows iteration does not take into account that a shadow that has a frame child might not be connected to the DOM. This results in a bug where a variable is expected to contain a WindowProxy but instead contains null. This problem was found @ MetaMask/metamask-extension#27756. This PR fixes that.

@weizman weizman changed the title bug fix Avoid null window within shadows Oct 27, 2024
@weizman weizman changed the title Avoid null window within shadows Skip unattached shadows Oct 27, 2024
@weizman weizman mentioned this pull request Oct 27, 2024
Closed
@weizman weizman mentioned this pull request Oct 28, 2024
Merged
naugtur
naugtur approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@naugtur naugtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also, reproduced the build locally and got no changes to the prod.js file.

@naugtur
Copy link
Member

naugtur commented Oct 28, 2024

Looks like the testing fell apart on CI update or something.

@weizman weizman merged commit 312f7e2 into main Oct 28, 2024
0 of 2 checks passed
@weizman weizman deleted the bug-fix branch October 28, 2024 12:16
@weizman weizman mentioned this pull request Jan 21, 2025
Merged
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this pull request Jan 29, 2025
@weizman
chore(lavamoat/lavadome): bump to v0.0.20 (#29691)
a707d19 
* LavaMoat/LavaDome#59
  * LavaMoat/LavaDome#38
  * LavaMoat/LavaDome#49
  * LavaMoat/LavaDome#42
* LavaMoat/snow#162
  * LavaMoat/snow#161
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this pull request Jan 29, 2025
@weizman
chore(lavamoat/lavadome): bump to v0.0.20 (#29691)
5f9e8c9 
* LavaMoat/LavaDome#59
  * LavaMoat/LavaDome#38
  * LavaMoat/LavaDome#49
  * LavaMoat/LavaDome#42
* LavaMoat/snow#162
  * LavaMoat/snow#161
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this pull request Jan 29, 2025
@weizman
chore(lavamoat/lavadome): bump to v0.0.20 (#29691)
ec2b966 
* LavaMoat/LavaDome#59
  * LavaMoat/LavaDome#38
  * LavaMoat/LavaDome#49
  * LavaMoat/LavaDome#42
* LavaMoat/snow#162
  * LavaMoat/snow#161
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this pull request Jan 30, 2025
@weizman
chore(lavamoat/lavadome): bump to v0.0.20 (#29691)
01dc051 
* LavaMoat/LavaDome#59
  * LavaMoat/LavaDome#38
  * LavaMoat/LavaDome#49
  * LavaMoat/LavaDome#42
* LavaMoat/snow#162
  * LavaMoat/snow#161
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this pull request Jan 30, 2025
@weizman
chore(lavamoat/lavadome): bump to v0.0.20 (#29691)
642fb08 
* LavaMoat/LavaDome#59
  * LavaMoat/LavaDome#38
  * LavaMoat/LavaDome#49
  * LavaMoat/LavaDome#42
* LavaMoat/snow#162
  * LavaMoat/snow#161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naugtur naugtur naugtur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weizman @naugtur